Added camera bag file to utilize in both perception pipeline demo and moveit_middleware_benchmark - #3
Merged
sjahr merged 4 commits intoAug 19, 2024
Conversation
… moveit_middleware_benchmark
2 tasks
sjahr
reviewed
Aug 12, 2024
sjahr
left a comment
sjahr
left a comment
Contributor
There was a problem hiding this comment.
On second thought, do you mind putting the bagfile into a new folder called something like rosbags, bagfiles etc? I think that would be cleaner. Because I'd probably do that: Don't forget to add that folder to the CMakeLists.txt install command 😉
sjahr
self-requested a review
August 12, 2024 09:37
Member
Author
|
Hello, Btw i've fixed the typo in author 😉 🆒 |
sjahr
approved these changes
Aug 14, 2024
Co-authored-by: Sebastian Jahr <sebastian.jahr@tuta.io>
Co-authored-by: Sebastian Jahr <sebastian.jahr@tuta.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, i wanted to add the bag file which it has some camera topics. I think it would be better to use this bag file for both perception pipeline demo and moveit_middleware_benchmark tool. Friendly tag here (@sjahr )