Skip to content

Add description how to add duration parameters in controller manager tutorial - #161

Merged
v4hn merged 1 commit into
moveit:kinetic-develfrom
2scholz:controller_params
Jun 25, 2018
Merged

Add description how to add duration parameters in controller manager tutorial#161
v4hn merged 1 commit into
moveit:kinetic-develfrom
2scholz:controller_params

Conversation

@2scholz

@2scholz 2scholz commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

This is in relation to moveit/moveit#785

I added an example of how to set these parameters.

I also added a description that details what these parameters do, due to the fact that I could not find any previous documentation of them in any of the tutorials.

@v4hn

v4hn commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

Hm, I don't think these parameters are relevant for the fake controller manager, so this feels like the wrong place for this information.
Could you add it here instead?

@2scholz
2scholz force-pushed the controller_params branch from 33da1eb to 432ef56 Compare April 5, 2018 16:12
@2scholz

2scholz commented Apr 5, 2018

Copy link
Copy Markdown
Contributor Author

Seems reasonable. I added the parameters to the existing YAML file examples for the arm and the gripper and provide a description of them below the examples.

@v4hn

v4hn commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

I added the parameters to the existing YAML file examples

That sounds like a good idea at first, but please don't.
These parameters are optional and the defaults are good enough for almost all users.
I think you already have a rough idea how confused most newcomers are by MoveIt's complexity, no need to fire an even longer yaml at them (at first).
So this deserves its own section below, possibly with its own example.

@2scholz
2scholz force-pushed the controller_params branch 2 times, most recently from f946765 to bb33e63 Compare April 6, 2018 14:36
@2scholz

2scholz commented Apr 6, 2018

Copy link
Copy Markdown
Contributor Author

I made the suggested changes and added a short example.

@2scholz
2scholz force-pushed the controller_params branch 3 times, most recently from fa30dd7 to f5b814a Compare May 30, 2018 12:51
@2scholz

2scholz commented May 30, 2018

Copy link
Copy Markdown
Contributor Author

I added a short description of the differences between the controller-specific values and the global ones.
I also rebased the branch, because the file was moved to a different directory recently.

@mlautman mlautman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description of the controller-specific duration parameters,
including a discussion of the difference to the global values,
as well as an example how to set them.
@v4hn
v4hn force-pushed the controller_params branch from f5b814a to bd5cbcb Compare June 25, 2018 11:42
@v4hn
v4hn merged commit 3d270a7 into moveit:kinetic-devel Jun 25, 2018
@v4hn

v4hn commented Jun 25, 2018

Copy link
Copy Markdown
Contributor

Thanks @2scholz !

Ridhwanluthra pushed a commit to Ridhwanluthra/moveit_tutorials that referenced this pull request Aug 6, 2018
Add a description of the controller-specific duration parameters,
including a discussion of the difference to the global values,
as well as an example how to set them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants