Skip to content

tutorial formatting and style rules - #179

Merged
v4hn merged 1 commit into
moveit:kinetic-develfrom
PickNikRobotics:formatting-rules
Jun 18, 2018
Merged

tutorial formatting and style rules#179
v4hn merged 1 commit into
moveit:kinetic-develfrom
PickNikRobotics:formatting-rules

Conversation

@mlautman

@mlautman mlautman commented Jun 7, 2018

Copy link
Copy Markdown
Contributor

Significant effort was put in to make the tutorials more consistent. This is my attempt to create structure so that future changes adhere to these same style, formatting and structure.

Once we come to an agreement here I can start fixing up the existing tutorials so that they better adhere to these guidelines.

@davetcoleman
@rhaschke
@v4hn

@davetcoleman davetcoleman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

Comment thread README.md
@@ -34,4 +34,47 @@ For deploying documentation changes to the web, [Section 3 of rosdoc_lite wiki](

## Contributing

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in intro sentence for the contributing section encouraging everyone to make the tutorials better :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md
├── <tutorial_name>_tutorial.rst
├── CMakeLists.txt # If the tutorial contains executable code
├── package.xml
├── setup.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# If the tutorial contains python

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is already covered by 'Tutorials should use the following directory structure omitting unnecessary files and subdirectories'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you shouldn't have '# If the tutorial contains executable code'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair. I'll standardize

Comment thread README.md Outdated
│ ├── __init__.py
│ ├── <tutorial_name>_tutorial.py # Main Python executable
│ └── <python_library>.py # Custom Python libraries
└── test/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Ideally tutorials have their own integration tests

@mlautman

Copy link
Copy Markdown
Contributor Author

Ping @v4hn @rhaschke

@rhaschke

Copy link
Copy Markdown
Contributor

Please send a reminder again after June, 25th. Currently, I'm too busy with preparing a demo for Automatica fair.

@v4hn
v4hn merged commit 691d271 into moveit:kinetic-devel Jun 18, 2018
Ridhwanluthra pushed a commit to Ridhwanluthra/moveit_tutorials that referenced this pull request Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants