Corrected tutorial's Cartesian path example - #190
Merged
davetcoleman merged 1 commit intoJul 10, 2018
Merged
Conversation
nbbrooks
commented
Jul 6, 2018
nbbrooks
commented
Contributor
- updated move_group_interface tutorial's Cartesian path waypoints (example 4) so path is triangular
- updated description of the path
Member
|
Failing because of #191 |
Contributor
|
@nbbrooks If you |
* updated move_group_interface tutorial's Cartesian path waypoints (example #4) so path is triangular * updated description of the path
mlautman
approved these changes
Jul 9, 2018
| target_pose3.position.y -= 0.1; | ||
| waypoints.push_back(target_pose3); // left | ||
| target_pose3.position.y -= 0.2; | ||
| waypoints.push_back(target_pose3); // right |
Contributor
There was a problem hiding this comment.
Technically this is subjective but I'll allow it 😝
Contributor
Author
There was a problem hiding this comment.
If the tutorial didn't mention the box appearing on the arm's right a little bit later in the lesson I would have left this alone :P
Member
There was a problem hiding this comment.
You could have just tweaked the tutorial text to say the arm's left ;-)
davetcoleman
approved these changes
Jul 10, 2018
Contributor
|
Congrats @nbbrooks! |
Ridhwanluthra
pushed a commit
to Ridhwanluthra/moveit_tutorials
that referenced
this pull request
Aug 6, 2018
* updated move_group_interface tutorial's Cartesian path waypoints (example moveit#4) so path is triangular * updated description of the path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.