python3 fixup: changed print syntax - #410
Merged
Merged
Conversation
rhaschke
reviewed
Oct 13, 2019
rhaschke
left a comment
rhaschke
left a comment
Contributor
There was a problem hiding this comment.
I generally approve those changes, but I'm curious why you didn't added
from __future__ import print_function?
I think this is needed to be still compatible with Python 2 as well, isn't it?
Member
|
I agree with @rhaschke , that would settle the print function use once and for all as it also disables Python2-style print statements. Make sure to put it as the first line of the file 👍 |
Contributor
Author
In this case it's not necessary, as all calls to |
bmagyar
approved these changes
Oct 17, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with ros-infrastructure/rosdoc_lite#90
this allows to build our docs with python3