Update getting_started.rst - #425
Closed
ngwk1 wants to merge 1 commit into
Closed
Conversation
Removed unnecessary line to clone moveit_tutorials.git which was already done in the previous wstool merge.
|
Thanks for helping in improving MoveIt! |
rhaschke
reviewed
Nov 20, 2019
rhaschke
left a comment
rhaschke
left a comment
Contributor
There was a problem hiding this comment.
I'm somewhat hesitant regarding this change: For experienced users, it is helpful to just have the git clone command there as well. On the other hand, you are right that inexperienced users get distracted by the error message.
When removing the clone command, the surrounding text needs to be adapted as well as indicated below.
| @@ -38,7 +38,6 @@ To easily follow along with these tutorials, you will need a **ROBOT_moveit_conf | |||
| Within your `catkin <http://wiki.ros.org/catkin>`_ workspace, download the tutorials as well as the ``panda_moveit_config`` package: :: | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Within your `catkin <http://wiki.ros.org/catkin>`_ workspace, download the tutorials as well as the ``panda_moveit_config`` package: :: | |
| Within your `catkin <http://wiki.ros.org/catkin>`_ workspace, download the ``panda_moveit_config`` package: :: |
Contributor
|
Friendly ping @ngwk1 |
Member
|
Replaced by #601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary line to clone
moveit_tutorials.gitwhich was already done in the previouswstool merge.This is to remove the issue of user facing:
fatal: destination path 'moveit_tutorials' already exists and is not an empty directory.while running:
git clone https://github.com/ros-planning/moveit_tutorials.git -b masterFixes #424.