Update now that all builtin Firefox modules are eslint modules#151
Merged
Conversation
skhamis
reviewed
Feb 20, 2025
| const { Weave } = ChromeUtils.importESModule("resource://services-sync/main.sys.mjs"); | ||
| const WeaveConstants = ChromeUtils.importESModule("resource://services-sync/constants.sys.mjs"); | ||
| const { XPCOMUtils } = ChromeUtils.importESModule("resource://gre/modules/XPCOMUtils.sys.mjs"); | ||
| const { XPCOMUtilsrg } = ChromeUtils.importESModule("resource://gre/modules/XPCOMUtils.sys.mjs"); |
Collaborator
There was a problem hiding this comment.
nit: remove the rg as it causes XPCOM to not load
mhammond
force-pushed
the
push-kprknpzkvsks
branch
from
ae78682 to
26655fc
Compare
skhamis
approved these changes
Feb 20, 2025
Collaborator
skhamis
left a comment
skhamis
left a comment
There was a problem hiding this comment.
Thanks for making these changes -- code look good to me, and testing it locally allows the addon to work again!
mhammond
force-pushed
the
push-kprknpzkvsks
branch
from
26655fc to
efb1eb6
Compare
willdurand
reviewed
Feb 26, 2025
| @@ -2,6 +2,8 @@ const { Log } = ChromeUtils.importESModule("resource://gre/modules/Log.sys.mjs") | |||
| const { Weave } = ChromeUtils.importESModule("resource://services-sync/main.sys.mjs"); | |||
| const WeaveConstants = ChromeUtils.importESModule("resource://services-sync/constants.sys.mjs"); | |||
Member
There was a problem hiding this comment.
Do you still need this since you de-structured the exported symbols on L5? (I caught this while reviewing the new version to be signed).
Collaborator
Author
There was a problem hiding this comment.
oh, no, you are correct, thanks. Should I remove it for "this" release, or is it fine to include it for the "next" release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a couple of fixes found by
npm auditand lists that it's only available for 136 and up.