Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Add lots of UA Overrides#37

Merged
skyschub merged 9 commits into
mozilla-extensions:masterfrom
skyschub:mass-ua-override
Nov 8, 2018
Merged

Add lots of UA Overrides#37
skyschub merged 9 commits into
mozilla-extensions:masterfrom
skyschub:mass-ua-override

Conversation

@skyschub
Copy link
Copy Markdown
Member

@skyschub skyschub commented Nov 8, 2018

This PR includes 9 additional UA Overrides for us to ship.

  • 7 of them are simply imports from ua-update.json.in so we eventually can remove the old mechanism.
  • The mobile.de override is tracked in bug 969844.
  • The mobile.bet365.com override is tracked in bug 1476436.

Testing these in current Fennec nightlies can be hard, as web-ext is not supporting them right now, see mozilla/web-ext#1391. However, testing in Beta works just fine, and so does compiling Fennec yourself. When testing the ua-update.json.in ports, be sure to toggle general.useragent.site_specific_overrides and general.useragent.updates.enabled to false to disable the old mechanism.

r? @wisniewskit

@skyschub skyschub changed the title [WIP] Add lots of UA Overrides Add lots of UA Overrides Nov 8, 2018
@skyschub skyschub requested a review from wisniewskit November 8, 2018 14:17
Copy link
Copy Markdown
Collaborator

@wisniewskit wisniewskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming these are all still necessary and work as advertised, r+

@skyschub skyschub merged commit 29694f3 into mozilla-extensions:master Nov 8, 2018
skyschub added a commit that referenced this pull request Nov 8, 2018
@skyschub skyschub deleted the mass-ua-override branch November 8, 2018 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants