Support forward declarations for C-like languages#1028
Conversation
The following files are removed - tests/expectations/std_lib_both.c - tests/expectations/std_lib_both.compat.c because opaque type definitions are replaced with forward declarations.
emilio
left a comment
There was a problem hiding this comment.
So... I'm not sure why we need a separate set around, it seems generally this should be tracked as part of Dependencies?
Also, I don't think we should unconditionally create forward declarations for non-problematic cases as you're doing here (anything that is a pointer gets forward-declared).
| library: &Library, | ||
| out: &mut Dependencies, | ||
| ptr_types: &mut IndexSet<GenericPath>, | ||
|
|
There was a problem hiding this comment.
nit: space. But also rather than having an is_ptr param, it seems this should be handled in Type::Ptr itself?
i'll check your points and modify this PR when i have time. |
Output forward declarations for C-like languages:
Limitations:
--style=typeis specifiedFixes #43