Add documentation for --watch-file - #910
Conversation
This PR adds documentation for the `--watch-file` option (that was missing). The behaviour for this option changed in mozilla/web-ext#2125.
|
Heads up for the linked issue #872. Just wanted to make a note of it so I can close it when this PR lands :) |
Question:Shouldn't the Suggestion:
I apologise for not catching these while #2125 was still under development. Just got around to it :-) cc: @rpl @Dexterp37 |
well, to be fair there are a number of other Alternatively we may use the same kind of approach we use for the Still not strictly mandatory, but I would definitely be ok to make that change before release the new web-ext version. @ankushduacodes This doesn't mean that your point wasn't a good one to raise, I actually appreciate you chiming in and point that out!
This sounds reasonable, we can still tweak the description in a separate PR (and maybe also add the
No need to apologies, and your timing is actually still pretty great, we do have time to follow up before this change is being released to the users. |
rpl
left a comment
There was a problem hiding this comment.
Just noticed that I didn't added the nit comment here after we merged that change on the web-ext side.
It is also totally fine to merge this as is and then add the alias in a separate PR, and so I'm also marking this version as approved.
|
|
||
| Environment variable: `$WEB_EXT_START_URL` | ||
|
|
||
| #### `--watch-file` |
There was a problem hiding this comment.
Nit, --watch-file, --watch-files (because we added the alias in web-ext v.6.0.0, mozilla/web-ext#2182)
Fixes #872
This PR adds documentation for the
--watch-fileoption (that was missing).The behaviour for this option changed in mozilla/web-ext#2125.