Bug 2018268 - fix: migrate script evaluation tools to WebDriver BiDi #98
Merged
Merged
Conversation
juliandescottes
force-pushed
the
bug2018268-part1
branch
from
4730d30 to
099531c
Compare
padenot
approved these changes
Jun 12, 2026
| }); | ||
|
|
||
| // Race against timeout as WebDriver BiDi callFunction has no built-in | ||
| // timeout feature. |
Collaborator
There was a problem hiding this comment.
Looks like this is https://www.w3.org/TR/webdriver-bidi/#issue-6eade172
Collaborator
Author
There was a problem hiding this comment.
Exactly, the topic hasn't moved much since we landed the initial script commands (to be clear, evaluate has the same issue, but it has a clearer TODO in the spec :) )
…r script evaluation
…iver BiDi for script evaluation
…LikelyStatement helpers
juliandescottes
force-pushed
the
bug2018268-part1
branch
from
099531c to
5e8d8f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for the debugging tool, we need to switch all script evaluation to BiDi. Main reason is that BiDi will automatically pick up the paused frame for script evaluation if you are stopped at a breakpoint, but WebDriver Classic will not.
Also taking the opportunity to align both the privileged script evaluation with the regular one. It frankly doesn't need a dedicated tool/command, but for now let's keep it as is.