test(functional): disable flaky vpn integration spec via test.fixme#20606
Merged
Conversation
Because: - The vpn integration "authorization flow - user already signed into Firefox" test fails intermittently in CI on the cached-signin click, blocking unrelated PRs. This commit: - Marks the single test in tests/misc/vpnIntegration.spec.ts with test.fixme so Playwright reports it as expected-failing and the pipeline stays green while the root cause is investigated on a separate branch.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables a flaky VPN integration Playwright test so it no longer blocks CI while the cached sign-in/WebChannel race is investigated.
Changes:
- Converts the VPN authorization-flow test to
test.fixme. - Adds a short comment explaining that the disablement is due to a cached-signin to WebChannel race.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
vpomerleau
approved these changes
May 15, 2026
Contributor
vpomerleau
left a comment
There was a problem hiding this comment.
Agree, let's disable this until the fix is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
How to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.