Skip to content

test(functional): disable flaky vpn integration spec via test.fixme#20606

Merged
vbudhram merged 1 commit into
mainfrom
disable-vpn-test
May 15, 2026
Merged

test(functional): disable flaky vpn integration spec via test.fixme#20606
vbudhram merged 1 commit into
mainfrom
disable-vpn-test

Conversation

@vbudhram
Copy link
Copy Markdown
Contributor

Because

  • The vpn integration "authorization flow - user already signed into Firefox" test fails intermittently in CI on the cached-signin click, blocking unrelated PRs.

This pull request

  • Marks the single test in tests/misc/vpnIntegration.spec.ts with test.fixme so Playwright reports it as expected-failing and the pipeline stays green while the root cause is investigated on a separate branch.

Issue that this pull request solves

Closes: (issue number)

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:

- The vpn integration "authorization flow - user already signed into
  Firefox" test fails intermittently in CI on the cached-signin click,
  blocking unrelated PRs.

This commit:

- Marks the single test in tests/misc/vpnIntegration.spec.ts with
  test.fixme so Playwright reports it as expected-failing and the
  pipeline stays green while the root cause is investigated on a
  separate branch.
@vbudhram vbudhram requested a review from a team as a code owner May 15, 2026 13:27
Copilot AI review requested due to automatic review settings May 15, 2026 13:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables a flaky VPN integration Playwright test so it no longer blocks CI while the cached sign-in/WebChannel race is investigated.

Changes:

  • Converts the VPN authorization-flow test to test.fixme.
  • Adds a short comment explaining that the disablement is due to a cached-signin to WebChannel race.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan has the fix for this in #20543 and it's been approved so not sure we want to disable this?

@vbudhram
Copy link
Copy Markdown
Contributor Author

Dan has the fix for this in #20543 and it's been approved so not sure we want to disable this?

@LZoog from meeting he said he was playing wackamole because it was introducing other test failures and I recommend we just disable it until we can figure it out.

Copy link
Copy Markdown
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, let's disable this until the fix is ready.

@vbudhram vbudhram merged commit 466d1d7 into main May 15, 2026
24 checks passed
@vbudhram vbudhram deleted the disable-vpn-test branch May 15, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants