chore(admin): deeplink to RP when creating WAF bypass token#20630
Open
toufali wants to merge 1 commit into
Open
chore(admin): deeplink to RP when creating WAF bypass token#20630toufali wants to merge 1 commit into
toufali wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the FxA Admin Panel workflow for creating WAF bypass tokens by preserving relying party (RP) context when navigating from an RP detail view to the WAF Tokens page, using query params to prefill the create-token form.
Changes:
- Add support in the WAF Tokens page to consume
createForClientIdandnamequery params, auto-open the create form, and then clear those params from the URL. - Add unit tests covering auto-open/prefill behavior and query param clearing.
- Update the Relying Parties page to deeplink to the WAF Tokens page with the appropriate prefill query params.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/fxa-admin-panel/src/components/PageWafTokens/index.tsx | Consume query params to prefill/auto-open the create token form and clear params from the URL. |
| packages/fxa-admin-panel/src/components/PageWafTokens/index.test.tsx | Add tests validating prefill/auto-open behavior and query param cleanup. |
| packages/fxa-admin-panel/src/components/PageRelyingParties/index.tsx | Update RP panel link to deeplink into token creation with RP context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8a2a3e6 to
96dab23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
createForClientIdandnamequery params so the WAF bypass form is prefilled with RP context.Issue that this pull request solves
Closes: FXA-13769
Checklist
Put an
xin the boxes that apply