[ci breaking-change] feat: discrete metrics as default#3067
Conversation
|
Do you want to mark this image with the |
|
Do you want to mark this image with the |
mikewilli
changed the title
scholtzan
left a comment
scholtzan
left a comment
There was a problem hiding this comment.
Some mypy issues, but otherwise lgtm
| # SPECIAL CASE DISCRETE METRICS LOGIC | ||
| # if the experiment's versioning date is before we flipped to discrete metrics as default | ||
| # then don't pass the --discrete-metrics flag | ||
| # unless --discrete-metrics was passed as an explicit command-line parameter | ||
| client = BigQueryClient(self.project_id, self.dataset_id) | ||
| DISCRETE_AS_DEFAULT_THRESHOLD = datetime(2026, 3, 26, tzinfo=pytz.UTC) | ||
| discrete_source = click.get_current_context().get_parameter_source("discrete_metrics") | ||
| explicit_discrete = discrete_source == ParameterSource.COMMANDLINE | ||
| discrete_metrics = ( | ||
| "--discrete-metrics" if self.discrete_metrics else "--no-discrete-metrics" | ||
| ) |
There was a problem hiding this comment.
should we create a ticket somewhere to remove this in a couple of months?
There was a problem hiding this comment.
Sure I can make a ticket. Not sure when we'll want to remove it, but a few months should be enough for everything but some holdbacks.
|
Do you want to mark this image with the |
2 participants
True--no-discrete-metricsfor ongoing experimentsdiscrete_metricsargo parameter to the experiment instead of workflow level (so that it can vary by experiment as needed)Edited to add:
[ci breaking-change]Also clarifying that the
DISCRETE_AS_DEFAULT_THRESHOLDdate is set to 2026-03-31 because I will plan to land this on 2026-03-30, which means the first run with discrete-as-default will be on 2026-03-31, and anything computed before that will used non-discrete logic.