This repository was archived by the owner on Sep 12, 2018. It is now read-only.
Pre: eliminate some occurrences of Rc, largely through the magic of Into.#658
Closed
rnewman wants to merge 1 commit into
Closed
Pre: eliminate some occurrences of Rc, largely through the magic of Into.#658rnewman wants to merge 1 commit into
rnewman wants to merge 1 commit into
Conversation
|
Leveraging rust type conversion definitely improves code quality, code is more normalized and refactoring have a lower impact. :) |
Merged
ncalexan
approved these changes
Apr 25, 2018
ncalexan
left a comment
ncalexan
left a comment
Member
There was a problem hiding this comment.
I'm fine with this, although I personally find .into() a constant frustration, since it's very difficult to follow even the types, let alone the concrete layout of the resulting instances.
Collaborator
Author
|
Landed via #659. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured this little polish would make work like #656 easier to read and experiment with. (@mmacedoeu, you might want to take a look.)