This repository was archived by the owner on Sep 12, 2018. It is now read-only.
Small improvements accumulated while building the logins API on top of Mentat.#779
Closed
ncalexan wants to merge 0 commit into
Closed
Small improvements accumulated while building the logins API on top of Mentat.#779ncalexan wants to merge 0 commit into
ncalexan wants to merge 0 commit into
Conversation
grigoryk
approved these changes
Jul 5, 2018
grigoryk
left a comment
grigoryk
left a comment
Contributor
There was a problem hiding this comment.
These look useful, and BindingTuple in particular makes life easier!
nit: something's off with your commit chain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These build on #778, and implement a variety of small fixes (related parts are labelled as such), and one non-trivial part -- matching tuple results with the
BindingTupletrait. In practice, this is very helpful, and greatly streamlined the logins API.