Replace react-content-marker with a regexp#3014
Merged
Merged
Conversation
mathjazz
reviewed
Nov 9, 2023
Collaborator
mathjazz
left a comment
mathjazz
left a comment
There was a problem hiding this comment.
There's a regression in string and concordance search - highlighting of placeables takes priority over highlighting the search match. It should be the other way around, because when searching, you care about search matches more:
https://pontoon.mozilla.org/sl/firefox/all-resources/?search=brand-full&string=192278
Other than that:
…fix, drop naming convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2515
Fixes #3006
Ports all the rules from
react-content-markerinto an inlined implementation. Results are cleaner, more efficient, and less buggy. Also, for placeholders we now match the rules used in the editor highlighting.In a few places the rules are relaxed a bit and/or made more sane, but these are unlikely to actually effect real-world messages noticably. Except where they fix current bugs. Also, the placeholder rules now match the editor.