feat: Added release channel as optional sign parameter (simple test) (#1400)

* feat: Added release channel as optional sign parameter
* test: Add test for sign channel parameter

Author: sneakypete81

src/cmd/sign.js

@@ -30,6 +30,7 @@ export type SignParams = {|
   sourceDir: string,
   timeout: number,
   verbose?: boolean,
+  channel?: string,
 |};
 
 export type SignOptions = {
@@ -57,6 +58,7 @@ export default function sign(
     sourceDir,
     timeout,
     verbose,
+    channel,
   }: SignParams,
   {
     build = defaultBuilder,
@@ -118,6 +120,7 @@ export default function sign(
         xpiPath: buildResult.extensionPath,
         version: manifestData.version,
         downloadDir: artifactsDir,
+        channel,
       });
 
       if (signingResult.id) {

src/program.js

@@ -412,6 +412,11 @@ Example: $0 --help run.
           describe: 'Number of milliseconds to wait before giving up',
           type: 'number',
         },
+        'channel': {
+          describe: 'The channel for which to sign the addon. Either ' +
+          '\'listed\' or \'unlisted\'',
+          type: 'string',
+        },
       })
     .command('run', 'Run the extension', commands.run, {
       'target': {

tests/unit/test-cmd/test.sign.js

@@ -288,6 +288,17 @@ describe('sign', () => {
     }
   ));
 
+  it('passes the channel parameter to the signer', () => withTempDir(
+    (tmpDir) => {
+      const stubs = getStubs();
+      return sign(tmpDir, stubs, {extraArgs: {channel: 'unlisted'}})
+        .then(() => {
+          sinon.assert.called(stubs.signAddon);
+          sinon.assert.calledWithMatch(stubs.signAddon, {channel: 'unlisted'});
+        });
+    }
+  ));
+
   it('passes the verbose flag to the signer', () => withTempDir(
     (tmpDir) => {
       const stubs = getStubs();