Skip to content

feat: Added release channel as optional sign parameter (simple test)#1400

Merged
rpl merged 2 commits into
mozilla:masterfrom
sneakypete81:sign_channel
Dec 14, 2018
Merged

feat: Added release channel as optional sign parameter (simple test)#1400
rpl merged 2 commits into
mozilla:masterfrom
sneakypete81:sign_channel

Conversation

@sneakypete81
Copy link
Copy Markdown
Contributor

Identical to #1250, but with a simplified test requested by @kumar303.

Added release channel as optional sign parameter. Fixes #877.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 5ebca9e on sneakypete81:sign_channel into b65226a on mozilla:master.

@rpl
Copy link
Copy Markdown
Member

rpl commented Dec 14, 2018

This looks good to me, and the failure on the travis windows worker was unrelated to this change (and it has been fixed in #1403).

Here is a successfully travis job which includes these changes on top of the fixes introduces in #1403:

I'm merging this now and I'm going to include it in the next web-ext release (which is going to be web-ext 2.9.3).

Thanks to @mi-g and @sneakypete81 for contributing this enhancement.

@rpl rpl merged commit 942c308 into mozilla:master Dec 14, 2018
@caitmuenster
Copy link
Copy Markdown

Thanks so much, @sneakypete81! Your contribution has been added to our recognition wiki.

Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you!

@wagnerand

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants