feat: Added release channel as optional sign parameter (simple test)#1400
Merged
Conversation
Member
|
This looks good to me, and the failure on the travis windows worker was unrelated to this change (and it has been fixed in #1403). Here is a successfully travis job which includes these changes on top of the fixes introduces in #1403: I'm merging this now and I'm going to include it in the next web-ext release (which is going to be web-ext 2.9.3). Thanks to @mi-g and @sneakypete81 for contributing this enhancement. |
|
Thanks so much, @sneakypete81! Your contribution has been added to our recognition wiki. Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you! |
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical to #1250, but with a simplified test requested by @kumar303.
Added release channel as optional sign parameter. Fixes #877.