fix: Move filename from global to build command option - #2178
Merged
Conversation
Member
Author
|
@Rob--W as also pointed out in the issue, this is technically a backward incompatible change from a config file perspective (if any user did figure out on their own that the filename config option had to be part of the global options and they were already using it) but given that we are going to release this in a new major version I'm not sure that is worth to apply more changes to keep compatibility with the "old config file format for this particular option". wdyt? |
Rob--W
approved these changes
Mar 3, 2021
Rob--W
left a comment
Rob--W
left a comment
Member
There was a problem hiding this comment.
sgtm. If we're bumping the version anyway, let's keep it simple.
This was referenced Mar 11, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2172