Skip to content

fix: Added alias for watch-file option #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpl merged 5 commits into from
Mar 10, 2021
Merged

fix: Added alias for watch-file option #2182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f088622
added alias for watch-file opt and updated option description to refl…
ankushduacodes Mar 5, 2021
ac9f65f
reverting the docs for watch-file
ankushduacodes Mar 5, 2021
9597f4d
reverting the docs for watch-file
ankushduacodes Mar 5, 2021
0c0eea4
Added test to check if alias is working as expected
ankushduacodes Mar 5, 2021
6058b2c
Merge branch 'add_alias_for_watch-file_opt' of https://github.com/ank…
ankushduacodes Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/program.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ Example: $0 --help run.
type: 'boolean',
},
'watch-file': {
alias: ['watch-files'],
describe: 'Reload the extension only when the contents of this' +
' file changes. This is useful if you use a custom' +
' build process for your extension',
Expand Down
9 changes: 7 additions & 2 deletions tests/functional/test.cli.run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,30 @@ const EXPECTED_MESSAGE = 'Fake Firefox binary executed correctly.';

describe('web-ext run', () => {

it('accepts: --no-reload --watch-file --source-dir SRCDIR ' +
'--firefox FXPATH --watch-ignored',
it('accepts: --no-reload --watch-file --watch-files --source-dir ' +
'SRCDIR --firefox FXPATH --watch-ignored',
() => withTempAddonDir(
{addonPath: minimalAddonPath},
(srcDir) => {
const watchedFile = path.join(srcDir, 'watchedFile.txt');
const watchedFilesArr = ['watchedFile1', 'watchedFile2'].map(
(file) => path.join(srcDir, file)
);
const watchIgnoredArr = ['ignoredFile1.txt', 'ignoredFile2.txt'].map(
(file) => path.join(srcDir, file)
);
const watchIgnoredFile = path.join(srcDir, 'ignoredFile3.txt');

fs.writeFileSync(watchedFile, '');
watchedFilesArr.forEach((file) => fs.writeFileSync(file, ''));
watchIgnoredArr.forEach((file) => fs.writeFileSync(file, ''));
fs.writeFileSync(watchIgnoredFile, '');

const argv = [
'run', '--verbose', '--no-reload',
'--source-dir', srcDir,
'--watch-file', watchedFile,
'--watch-files', ...watchedFilesArr,
'--firefox', fakeFirefoxPath,
'--watch-ignored', ...watchIgnoredArr,
'--watch-ignored', watchIgnoredFile,
Expand Down