rust-analyze: only stick with the deps/save-analysis file, instead of all of them.#81
rust-analyze: only stick with the deps/save-analysis file, instead of all of them.#81emilio wants to merge 4 commits intomozsearch:masterfrom
Conversation
|
This unblocks servo. |
staktrace
left a comment
staktrace
left a comment
There was a problem hiding this comment.
This looks fine to me, although the backslash seems weird. I would have expected quotes around "deps/save-analysis" to do the job.
It looks like on m-c all the analysis goes into deps/save-analysis so this shouldn't affect m-c at all.
The Rust indexer is about to create stuff under __GENERATED__.
It's easier to figure out mismatches for rls-data, for example.
It's not clear the shell script accounts correctly for whitespace in the paths. That being said it's not clear other scripts do so, and we have control over the paths anyway.
|
@emilio Is there anything from this patch we still want noting that we may want to switch to using LSIF for rust (https://bugzilla.mozilla.org/show_bug.cgi?id=1761287) and that I think I addressed the generated files issues in other patches (#299 and #339 maybe based on blame)? Note that the rust stuff is not super high on my personal priority list right now, but the JS LSIF stuff is (https://bugzilla.mozilla.org/show_bug.cgi?id=1740290), and there's a good chance of there being synergies there. |
|
Yeah, let's close for now. |
3 participants
When building with crates.io, all the crate dependencies also get save-analysis
dirs.
We probably want to use them, but not quite yet.