[Sprint 19] clean up remaining repo-wide Release build analyzer warnings

[mpaulosky]

Summary

dotnet build MyBlog.slnx --configuration Release --no-restore still succeeds with 46 warnings after PR #279 cleaned the profile-email slice. This issue tracks the remaining repo-wide warning debt outside the files touched by PR #279.

Current state

• Release build baseline: 46 warnings
• PR fix(profile): fall back to authenticated email claims on /profile #279 already removed touched-file warnings in the profile-email slice
• This issue is for the remaining repo-wide warning debt elsewhere in the solution

Top warning categories

• CA2007 — e.g. src/Web/Components/Theme/ThemeProvider.razor.cs, src/Web/Data/MongoDbBlogPostRepository.cs, src/Web/Infrastructure/Caching/BlogPostCacheService.cs
• CA1307 — e.g. tests/Web.Tests.Bunit/Components/RazorSmokeTests.cs
• CA1515 — e.g. src/Web/Data/BlogDbContext.cs, src/Web/Components/Theme/ThemeProvider.razor.cs
• Smaller pockets remain for CA1014, CA1062, CA1812, CA1826, and CA1865

Why it matters

• Warning debt obscures real regressions in local builds and CI
• It slows the path back to zero-warning Release-build enforcement
• New diagnostics are easier to miss when the baseline already contains noise

Acceptance Criteria

• Re-run the Release build and capture the current warning baseline by ID and file
• Reduce or eliminate the remaining warning set outside PR fix(profile): fall back to authenticated email claims on /profile #279's touched files
• Fix the highest-volume categories first (CA2007, CA1307, CA1515)
• Any warning that must remain is explicitly justified with a targeted suppression or a follow-up issue
• The final issue update reports the new warning count and any intentional deferrals
• Stretch goal: return dotnet build MyBlog.slnx --configuration Release --no-restore to zero warnings

Sprint

Sprint 19

[github-actions]

🏗️ Squad Triage — Aragorn (Lead / Architect)

Issue: #280 — [Sprint 19] clean up remaining repo-wide Release build analyzer warnings
Assigned to: Legolas (Frontend / Blazor)
Reason: Issue relates to frontend/UI work

Team roster:

• Aragorn (Lead / Architect) → label: squad:aragorn
• Sam (Backend / .NET) → label: squad:sam
• Legolas (Frontend / Blazor) → label: squad:legolas
• Gimli (Tester) → label: squad:gimli
• Boromir (DevOps / Infra) → label: squad:boromir
• Gandalf (Security / Auth) → label: squad:gandalf
• Frodo (Tech Writer) → label: squad:frodo
• Pippin (Docs) → label: squad:pippin
• Bilbo (Tech Blogger) → label: squad:bilbo
• Ralph (Meta) → label: squad:ralph

To reassign, remove the current squad:* label and add the correct one.

[mpaulosky]

🔄 Ralph triage update

Fresh rebaseline for #280 on a clean dev worktree shows the issue is currently blocked before warning cleanup begins:

• dotnet restore MyBlog.slnx fails with NU1902
• vulnerable transitive package: SharpCompress 0.30.1
• advisory: GHSA-6c8g-7p36-r338
• affected projects include src/Web, src/AppHost, tests/Web.Tests, tests/Web.Tests.Bunit, tests/Web.Tests.Integration, tests/Architecture.Tests, and tests/AppHost.Tests

That means the issue cannot be treated as a pure Blazor/UI warning pass yet. The fresh dev baseline must first clear the restore gate, then warning cleanup can be split by domain.

Routing adjustment

• keeping squad:legolas for the eventual UI/analyzer slice
• adding squad:boromir for the immediate package / restore blocker

Suggested next split after restore is green

• Legolas: src/Web/Components/**, .razor/.razor.cs, tests/Web.Tests.Bunit/**
• Sam: src/Web/Data/**, src/Web/Infrastructure/**
• Boromir: package / build / infra diagnostics

[github-actions]

📋 Assigned to Boromir (DevOps / Infra)

Issue: #280 — [Sprint 19] clean up remaining repo-wide Release build analyzer warnings

Boromir will pick this up in the next Copilot session.

For Copilot coding agent: If enabled, this issue will be worked automatically.
Otherwise, start a Copilot session and say:
Boromir, work on issue #280

[github-actions]

📋 Assigned to Aragorn (Lead / Architect)

Issue: #280 — [Sprint 19] clean up remaining repo-wide Release build analyzer warnings

Aragorn will pick this up in the next Copilot session.

For Copilot coding agent: If enabled, this issue will be worked automatically.
Otherwise, start a Copilot session and say:
Aragorn, work on issue #280