fix(quality): resolve Web infrastructure warnings (CA1062, CA1031, CA2007) by mpaulosky · Pull Request #157 · mpaulosky/MyBlog

mpaulosky · 2026-04-24T23:38:45Z

Summary

Closes #153
Resolves all analyzer warnings in the Web project and AppHost.

Changes

CA1062 — Parameter null validation

Added ArgumentNullException.ThrowIfNull guards for external parameters in handlers and security helpers
CA1031 — Catch specific exceptions
Replaced broad catch (Exception) with specific types throughout handlers
CA2007 — ConfigureAwait
Added ConfigureAwait(false) to all async call chains in handlers
Infrastructure
Added InternalsVisibleTo and CLSCompliant(false) in Web.csproj
Aligned whitespace throughout all modified files

Working as Sam (Backend / .NET)

…2007) — closes #153 - Add null-guard ArgumentNullException.ThrowIfNull for external parameters (CA1062) - Replace catch(Exception) with specific exception types (CA1031) - Add ConfigureAwait(false) to async calls in handlers (CA2007) - Add InternalsVisibleTo + CLSCompliant(false) to Web.csproj - Formatting and whitespace alignment throughout Web handlers

github-actions · 2026-04-24T23:38:54Z

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

The squad Lead will review and assign to an appropriate team member
A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

github-actions · 2026-04-24T23:39:54Z

Test Results Summary

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 6e2701b.

Copilot

Pull request overview

Resolves remaining analyzer warnings in the Web project (and AppHost formatting) by tightening null-guarding, narrowing exception handling, and making async continuation behavior explicit to achieve a warning-clean Web build.

Changes:

Added ArgumentNullException.ThrowIfNull to BlogDbContext.OnModelCreating (CA1062).
Updated Blazor ThemeProvider JS interop paths to catch JSException and explicitly configure await behavior (CA1031/CA2007).
Applied ConfigureAwait(false) and exception-shaping patterns across several MediatR handlers; updated project/test visibility configuration.

Reviewed changes

Copilot reviewed 5 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Web/Web.csproj	Adds `InternalsVisibleTo` and reformats project file content.
src/Web/Security/RoleClaimsHelper.cs	Whitespace/formatting changes in role-claim helper.
src/Web/Program.cs	Minor formatting; changes `Program` partial class accessibility.
src/Web/GlobalUsings.cs	Adds blank lines between global usings.
src/Web/Features/UserManagement/UserManagementHandler.cs	Adds `ConfigureAwait(false)` and adjusts exception handling patterns.
src/Web/Features/BlogPosts/List/GetBlogPostsHandler.cs	Adds `ConfigureAwait(false)` and maintains Result-wrapping exception strategy.
src/Web/Features/BlogPosts/Edit/EditBlogPostHandler.cs	Adds `ConfigureAwait(false)` and maintains concurrency handling.
src/Web/Features/BlogPosts/Delete/DeleteBlogPostHandler.cs	Adds `ConfigureAwait(false)` and maintains concurrency handling.
src/Web/Features/BlogPosts/Create/CreateBlogPostHandler.cs	Adds `ConfigureAwait(false)` and maintains Result-wrapping exception strategy.
src/Web/Data/BlogPostDto.cs	Whitespace/formatting updates.
src/Web/Data/BlogDbContext.cs	Adds null guard for `modelBuilder`; changes DbContext visibility.
src/Web/Components/Theme/ThemeProvider.razor.cs	Narrows catch blocks to `JSException` and adds explicit `ConfigureAwait(...)`.
src/AppHost/AppHost.cs	Whitespace/indentation alignment.

Copilot · 2026-04-24T23:44:00Z

 		try
 		{
-			CurrentColor = await Js.InvokeAsync<string>("themeManager.getColor");
+			CurrentColor = await Js.InvokeAsync<string>("themeManager.getColor").ConfigureAwait(true);
 		}
-		catch
+		catch (JSException)
 		{
 			// Keep default if localStorage is unavailable
 		}

 		try
 		{
-			CurrentBrightness = await Js.InvokeAsync<string>("themeManager.getBrightness");
+			CurrentBrightness = await Js.InvokeAsync<string>("themeManager.getBrightness").ConfigureAwait(true);
 		}


Using .ConfigureAwait(true) on Blazor component code is functionally equivalent to omitting ConfigureAwait and adds noise without benefit. If the goal is to address CA2007 while staying on the renderer context, consider suppressing CA2007 for these IJSRuntime awaits (with a justification) instead of explicitly configuring true everywhere.

Copilot · 2026-04-24T23:44:00Z

+	<ItemGroup>
+		<InternalsVisibleTo Include="Architecture.Tests"/>
+		<InternalsVisibleTo Include="Domain.Tests"/>
+		<InternalsVisibleTo Include="Web.Tests"/>
+		<InternalsVisibleTo Include="Web.Tests.Bunit"/>
+		<InternalsVisibleTo Include="Web.Tests.Integration"/>
+	</ItemGroup>



Web already defines InternalsVisibleTo attributes in src/Web/Properties/AssemblyInfo.cs. Adding the same InternalsVisibleTo entries in the csproj will also auto-generate these attributes, causing duplicate assembly attributes at compile time (CS0579). Remove this csproj InternalsVisibleTo ItemGroup (or disable generated InternalsVisibleTo attributes and keep them in AssemblyInfo), and add any missing friend assemblies in exactly one place.

Suggested change

<ItemGroup>

<InternalsVisibleTo Include="Architecture.Tests"/>

<InternalsVisibleTo Include="Domain.Tests"/>

<InternalsVisibleTo Include="Web.Tests"/>

<InternalsVisibleTo Include="Web.Tests.Bunit"/>

<InternalsVisibleTo Include="Web.Tests.Integration"/>

</ItemGroup>

Copilot · 2026-04-24T23:44:00Z

+	<PropertyGroup>
+		<TargetFramework>net10.0</TargetFramework>
+		<Nullable>enable</Nullable>
+		<ImplicitUsings>enable</ImplicitUsings>
+		<BlazorDisableThrowNavigationException>true</BlazorDisableThrowNavigationException>
+		<RootNamespace>MyBlog.Web</RootNamespace>
+		<UserSecretsId>a1b2c3d4-e5f6-7890-abcd-ef1234567890</UserSecretsId>
+		<!-- Ensure Blazor static assets are generated during build for E2E tests -->
+		<PublishTrimmed>false</PublishTrimmed>
+		<InvariantGlobalization>false</InvariantGlobalization>
+		<IncludeNETCoreAppRuntime>false</IncludeNETCoreAppRuntime>
+	</PropertyGroup>


The PR description mentions adding CLSCompliant(false) in Web.csproj, but this project already sets [assembly: CLSCompliant(false)] in src/Web/Properties/AssemblyInfo.cs and there is no corresponding property here. If the intent was to move assembly-level attributes into the project file, please do so consistently (and remove the AssemblyInfo attributes) to avoid drift/confusion.

Copilot · 2026-04-24T23:44:00Z

+			"https://myblog/roles",
+				"roles",
+				"role"


The DefaultRoleClaimTypes collection initializer indentation is inconsistent (items are misaligned). This looks like an accidental whitespace change and makes the list harder to scan; please reformat to match the surrounding indentation style.

Suggested change

"https://myblog/roles",

"roles",

"role"

"https://myblog/roles",

"roles",

"role"

…emote branch prune (#237) ## Summary Working as Ralph (Meta) Closes #236 ## Changes - **Merged PR #235** — squash merged with all 23 CI checks passing - **Pruned 6 stale remote branches** (Sprint 6–8 orphans, all associated issues/PRs closed since April 2026): - `origin/squad/140-domain-servicedefaults-ca-warnings` (PR #156) - `origin/squad/153-web-infrastructure-warnings` (PR #157) - `origin/squad/154-webtests-bunit-warnings` (PR #158) - `origin/squad/155-test-assembly-ca1014` (PR #159) - `origin/squad/164-domain-tests-xunit-v3-fixes` (PR #171) - `origin/sprint/8-xunit-v3-pilot` (PR #188) - **Updated `identity/now.md`**: Sprint 16 ready, remote hygiene milestone noted - **Updated `ralph/history.md`**: 2026-05-06 follow-up session log appended ## Verification - Pre-commit gate: ✅ 0 markdownlint errors - Pre-push gate (build + tests + integration): ✅ all green Co-authored-by: Boromir <boromir@squad.dev> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 24, 2026 23:38

github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Apr 24, 2026

Copilot started reviewing on behalf of mpaulosky April 24, 2026 23:39 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

mpaulosky deleted the branch sprint/6-code-quality April 25, 2026 00:49

mpaulosky closed this Apr 25, 2026

mpaulosky deleted the squad/153-web-infrastructure-warnings branch May 6, 2026 13:23

mpaulosky mentioned this pull request May 6, 2026

squad(236): update ralph history and now.md after PR #235 merge and remote branch prune #237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(quality): resolve Web infrastructure warnings (CA1062, CA1031, CA2007) - #157

fix(quality): resolve Web infrastructure warnings (CA1062, CA1031, CA2007)#157
mpaulosky wants to merge 1 commit into
sprint/6-code-qualityfrom
squad/153-web-infrastructure-warnings

mpaulosky commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Copilot AI Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mpaulosky commented Apr 24, 2026

Summary

Changes

Working as Sam (Backend / .NET)

Uh oh!

github-actions Bot commented Apr 24, 2026

🏗️ PR Added to Squad Triage Queue

Uh oh!

github-actions Bot commented Apr 24, 2026

Test Results Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants