Skip to content

docs: Sprint 7 xUnit v3 pilot retrospective template (#167)#172

Merged
mpaulosky merged 1 commit into
sprint/7-xunit-v3-pilotfrom
squad/167-sprint7-retro
Apr 25, 2026
Merged

docs: Sprint 7 xUnit v3 pilot retrospective template (#167)#172
mpaulosky merged 1 commit into
sprint/7-xunit-v3-pilotfrom
squad/167-sprint7-retro

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Summary

Working as Aragorn (Lead Developer)

Closes #167

Phase 1 of the Sprint 7 xUnit v3 pilot retrospective process. Creates the template and tracking infrastructure that will be filled in at sprint end (Phase 2, after #162#166 merge).


What's in this PR

docs/sprint-7-xunit-v3-pilot-retro.md

Full retrospective template with:

  • Context — sprint theme, branch, issue scope
  • Pilot Scope — Domain.Tests only; table showing Sprints 8–10 targets
  • Metrics to Track — build time, test count/pass rate/exec time, coverage %, CI feedback time
  • Success Criteria — checkbox list Aragorn will validate at sprint end
  • Results / Lessons Learned / Decision — placeholder sections for Phase 2
  • Migration Playbook (Draft) — package change stubs for Unit.Tests/Architecture.Tests/Blazor.Tests reuse

Local tracking doc (.squad/decisions/inbox/ — gitignored)

  • aragorn-sprint7-xunit-pilot-tracking.md — live log for build breaks, test failures, CI issues, API breaking changes, package compatibility, and sprint metrics
  • aragorn-sprint7-pilot-plan.md — decision record for the phased migration approach

Retro approach

Phase Trigger Action
Phase 1 (now) Sprint kickoff Create template + tracking infrastructure
Phase 2 (sprint end) #162#166 all merged Run validation, gather metrics, fill in retro, deliver go/no-go decision

Phase 2 will add a second commit to this branch finalising the report and closing #167.


⚠️ This task was flagged as "needs review" — the Phase 2 retro content (results, decision, lessons learned) should be verified by Boromir (CI metrics) and Gimli (test metrics) before the final commit merges.

…#167)

- Add docs/sprint-7-xunit-v3-pilot-retro.md with full retro template:
  Context, Pilot Scope, Metrics to Track, Success Criteria, and
  placeholder sections for Results, Lessons Learned, and Decision
- Template will be filled in by Aragorn after issues #162-#166 merge
- Tracking doc created locally in .squad/decisions/inbox/ (gitignored)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 25, 2026 02:01
@github-actions github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Apr 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

  • The squad Lead will review and assign to an appropriate team member
  • A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Sprint 7 xUnit v3 pilot retrospective report template to support tracking metrics, success criteria, and the go/no-go decision for rolling migration to additional test projects.

Changes:

  • Introduces a new retrospective template document for Sprint 7’s xUnit v3 pilot (Domain.Tests scope).
  • Defines placeholders for metrics, success criteria, results/lessons learned, and a draft migration playbook section.

Comment on lines +167 to +175
```xml
<!-- xUnit v2 (remove) -->
<PackageReference Include="xunit" Version="2.*" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.*" />

<!-- xUnit v3 (add) -->
<PackageReference Include="xunit.v3" Version="..." />
<PackageReference Include="xunit.runner.visualstudio" Version="3.*" />
```

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package-change snippet doesn’t match the repo’s Central Package Management setup (versions are managed in Directory.Packages.props, and csproj PackageReferences typically omit Version=). Also, wildcard versions like 2.*/3.* aren’t ideal for a migration playbook because they reduce repeatability.

Suggestion: show (a) the csproj PackageReference entries without versions, and/or (b) the corresponding PackageVersion entries to add/update in Directory.Packages.props for xUnit v2/v3 and xunit.runner.visualstudio.

Copilot uses AI. Check for mistakes.
| `tests/Domain.Tests` | ✅ Migrated to xUnit v3 | Gimli |
| `tests/Unit.Tests` | 🔜 Planned (Sprint 8) | Gimli |
| `tests/Architecture.Tests` | 🔜 Planned (Sprint 9) | Gimli |
| `tests/Blazor.Tests` (bUnit) | 🔜 Planned (Sprint 10) | Gimli |

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table rows start with || which renders an unintended empty first column in Markdown. Use a single leading | (or no leading pipe) for each row and apply the same fix to the other tables in this document.

Also, tests/Blazor.Tests doesn’t exist in this repo (the bUnit project is tests/Web.Tests.Bunit). Please update the project name here (and anywhere else it appears) to match the actual test project folder/name.

Suggested change
| `tests/Blazor.Tests` (bUnit) | 🔜 Planned (Sprint 10) | Gimli |
| `tests/Web.Tests.Bunit` (bUnit) | 🔜 Planned (Sprint 10) | Gimli |

Copilot uses AI. Check for mistakes.
- [ ] Line coverage ≥ 80% (no regression from Sprint 6 baseline)
- [ ] Release build (`dotnet build -c Release`) exits 0 with 0 errors
- [ ] CI workflow `squad-test.yml` passes end-to-end on the sprint branch
- [ ] No breaking change propagates to `Unit.Tests`, `Architecture.Tests`, or `Blazor.Tests`

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blazor.Tests isn’t a test project in this repo; the bUnit suite is tests/Web.Tests.Bunit. Update this success criterion to reference the correct project(s) so the checklist matches the actual rollout surface area.

Suggested change
- [ ] No breaking change propagates to `Unit.Tests`, `Architecture.Tests`, or `Blazor.Tests`
- [ ] No breaking change propagates to `Unit.Tests`, `Architecture.Tests`, or `tests/Web.Tests.Bunit`

Copilot uses AI. Check for mistakes.

### Issues Encountered

- _TBD — see tracking doc `.squad/decisions/inbox/aragorn-sprint7-xunit-pilot-tracking.md`_

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This references a tracking doc under .squad/decisions/inbox/…, but that directory is gitignored in this repo, so readers won’t be able to find it. Consider either (1) moving the tracking log to a committed location (e.g., under docs/), or (2) explicitly calling out that it’s a local-only log and linking to the committed source of truth (issue/PR links, .squad/decisions.md, etc.).

Suggested change
- _TBD — see tracking doc `.squad/decisions/inbox/aragorn-sprint7-xunit-pilot-tracking.md`_
- _TBD — local working notes were tracked in the gitignored file
`.squad/decisions/inbox/aragorn-sprint7-xunit-pilot-tracking.md`; record the
committed summary and source of truth in `.squad/decisions.md`._

Copilot uses AI. Check for mistakes.
Comment on lines +146 to +151
| Sprint | Scope | Owner |
|---|---|---|
| Sprint 8 | Migrate `tests/Unit.Tests` | Gimli |
| Sprint 9 | Migrate `tests/Architecture.Tests` | Gimli |
| Sprint 10 | Migrate `tests/Blazor.Tests` (bUnit) | Gimli + Legolas |

Copilot AI Apr 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table also uses the || prefix which creates an empty first column in Markdown. Additionally, tests/Blazor.Tests doesn’t exist here; the bUnit project is tests/Web.Tests.Bunit. Please update both the table formatting and the project name so the next-steps plan matches the repo structure.

Copilot uses AI. Check for mistakes.
@github-actions

Copy link
Copy Markdown
Contributor

Test Results Summary

209 tests  ±0   209 ✅ ±0   14s ⏱️ ±0s
  5 suites ±0     0 💤 ±0 
  5 files   ±0     0 ❌ ±0 

Results for commit a33c5f6. ± Comparison against base commit e7035b1.

@codecov

codecov Bot commented Apr 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.12%. Comparing base (e7035b1) to head (a33c5f6).
⚠️ Report is 5 commits behind head on sprint/7-xunit-v3-pilot.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           sprint/7-xunit-v3-pilot     #172   +/-   ##
========================================================
  Coverage                    72.12%   72.12%           
========================================================
  Files                           43       43           
  Lines                          721      721           
  Branches                       112      112           
========================================================
  Hits                           520      520           
  Misses                         150      150           
  Partials                        51       51           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpaulosky
mpaulosky merged commit 18e668f into sprint/7-xunit-v3-pilot Apr 25, 2026
19 of 20 checks passed
@mpaulosky
mpaulosky deleted the squad/167-sprint7-retro branch April 25, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad Squad triage inbox — Lead will assign to a member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants