feat: add xUnit v3 packages to Directory.Packages.props (#162)#173
Merged
mpaulosky merged 2 commits intoApr 25, 2026
Merged
Conversation
Add xUnit v3.2.2 (stable) metapackage family and analyzers to centralized NuGet version management. xUnit v2 (2.9.3) retained for backward compat until all test projects are migrated. New packages: - xunit.v3 3.2.2 — main v3 metapackage - xunit.v3.assert 3.2.2 — v3 assertion library - xunit.v3.extensibility.core 3.2.2 — v3 extensibility hooks - xunit.analyzers 1.27.0 — Roslyn analyzers (v2 + v3 compatible) xunit.runner.visualstudio 3.1.5 already present and supports v3. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…166) - Document pilot scope: Domain.Tests in Sprint 7 - Include v3 rationale: MTP adoption, performance gains, ecosystem alignment - Provide rollout plan: Sprints 7–13, per-project versioning strategy - Add performance analysis: baseline metrics (104ms Domain.Tests), projected 5–15% improvement - Include migration examples: before/after test code, API changes - Outline risk mitigation: incremental rollout, measurement plan, fallback strategy Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
github-actions
Bot
added
the
squad
There was a problem hiding this comment.
Pull request overview
Adds centralized NuGet package versions for the xUnit v3 package family to enable a gradual v2→v3 migration, and documents the Sprint 7 pilot decision via a new ADR.
Changes:
- Added centralized
PackageVersionentries forxunit.v3and related packages (plusxunit.analyzers) inDirectory.Packages.props. - Added an ADR describing the Sprint 7–13 xUnit v3 migration plan/pilot and rationale.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Directory.Packages.props |
Adds xUnit v3 and analyzer package versions to the centralized NuGet version manifest. |
docs/adr/sprint7-xunit-v3-migration.md |
Introduces an ADR capturing the xUnit v3 pilot decision, rollout plan, and references. |
| ```xml | ||
| <ItemGroup> | ||
| <PackageVersion Include="xunit" Version="2.9.3" /> | ||
| <PackageVersion Include="xunit.v3" Version="3.0.x" /> |
There was a problem hiding this comment.
The example Directory.Packages.props snippet pins xunit.v3 to 3.0.x, but this PR centralizes xunit.v3 at 3.2.2. To avoid confusing readers during the rollout, update the snippet to match the actual version (or use a generic 3.x placeholder if you intentionally don't want to pin a specific minor/patch in the ADR).
Suggested change
| <PackageVersion Include="xunit.v3" Version="3.0.x" /> | |
| <PackageVersion Include="xunit.v3" Version="3.2.2" /> |
Comment on lines
+1
to
+4
| --- | ||
| post_title: "ADR: Migrate to xUnit v3 (Pilot)" | ||
| author1: "Pippin" | ||
| post_slug: "adr-sprint7-xunit-v3-migration" |
There was a problem hiding this comment.
PR description/summary currently only mentions adding xUnit v3 packages to Directory.Packages.props, but this PR also introduces a new ADR document. Please update the PR description to include the ADR addition (or split the ADR into a separate PR) so the change scope is accurately reflected.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## sprint/7-xunit-v3-pilot #173 +/- ##
========================================================
Coverage 72.12% 72.12%
========================================================
Files 43 43
Lines 721 721
Branches 112 112
========================================================
Hits 520 520
Misses 150 150
Partials 51 51 🚀 New features to boost your workflow:
|
mpaulosky
added a commit
that referenced
this pull request
Apr 25, 2026
…#165) (#174) ## Summary Adds a `test-domain` job to `squad-test.yml` to validate that Domain.Tests runs correctly in CI under xUnit v3. This unblocks Gimli's migration work (#163/#164) — the CI pipeline is ready before test code is written. ## Changes **`.github/workflows/squad-test.yml`** — 3 targeted edits: 1. **New `test-domain` job** — runs `tests/Domain.Tests` with the same pattern as other test jobs: - `dotnet build` + `dotnet test --no-build` (Release config) - `--collect:"XPlat Code Coverage"` with Cobertura format - TRX logger → `domain-test-results` artifact - Guard clause: skips gracefully if project not found 2. **`coverage` job** — added `test-domain` to `needs` list so Domain.Tests coverage is included in the report 3. **`report` job** — added `test-domain` to `needs` list and job summary output; added `domain_status` to the overall failure gate ## xUnit v3 CI Compatibility No runner/tool changes were required: | Tool | v2 compat | v3 compat | Notes | |------|-----------|-----------|-------| | `dotnet test` | ✅ | ✅ | No changes needed | | `XPlat Code Coverage` | ✅ | ✅ | Coverlet collector works unchanged | | TRX logger | ✅ | ✅ | Standard .NET test output | | `EnricoMi/publish-unit-test-result-action` | ✅ | ✅ | Reads TRX, not xUnit-specific | | `coverlet.collector` 10.0.0 | ✅ | ✅ | Already in Directory.Packages.props | ## Depends on PR #173 (feat: add xUnit v3 packages to Directory.Packages.props) should merge first so the NuGet packages are available. Closes #165 --- *Working as Boromir (DevOps engineer) — CI/CD pipeline management* Co-authored-by: Boromir <boromir@squad.dev> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds xUnit v3 (3.2.2 stable) package family to
Directory.Packages.propsas part of Sprint 7 xUnit v3 pilot.Changes
Directory.Packages.props— added 4 package versions to the centralized NuGet manifest:xunit.v3xunit.v3.assertxunit.v3.extensibility.corexunit.analyzersxunit(2.9.3) andxunit.runner.visualstudio(3.1.5) were already present and are retained.Notes
Directory.Packages.propsper team convention — no version attributes added to any.csprojdotnet restoreverified locally — no resolution errorsxunit 2.9.3) is retained for backward compatibility while other test projects migrateCloses #162
Working as Boromir (DevOps engineer) — NuGet centralized version management