CI validation for xUnit v3 (#177)

[mpaulosky]

Summary

Closes #177

Working as Boromir (DevOps Engineer)

Validates CI passes cleanly with xUnit v3 packages in Architecture.Tests (from #176) and Domain.Tests (Sprint 7 pilot).

CI Validation Findings

Local Build & Test Results

Step	Result	Notes
dotnet restore	✅ PASS	All packages resolved
dotnet build --configuration Release	✅ PASS	0 errors, 306 pre-existing warnings (CA2007/CA1707 in integration tests — not xunit-related, pre-existing)
dotnet test tests/Architecture.Tests	✅ PASS	11/11 tests passed
dotnet test tests/Domain.Tests	✅ PASS	42/42 tests passed

Workflow Assessment

Workflow	Behaviour	Status
squad-ci.yml	Build-only gate on PR to dev/main	✅ No changes needed
squad-preview.yml	Full test suite on push to dev	⚠️ Domain.Tests was missing — added

Workflow Change

squad-preview.yml — Added dotnet test tests/Domain.Tests to the test matrix. The Sprint 7 Domain.Tests pilot was missing from CI gate despite being the reference implementation. Architecture.Tests was already present and now validates with xunit.v3.

No Adjustments Needed

xUnit v3 3.2.2 works drop-in with Microsoft.NET.Test.Sdk 18.5.0 and xunit.runner.visualstudio 3.1.5 (already centralized in Directory.Packages.props). No runner configuration changes required beyond the xunit.runner.json added in #176.

⚠️ This task was flagged as "needs review" — please have a squad member review before merging (CI workflow changes affect all contributors).

[github-actions]

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

• The squad Lead will review and assign to an appropriate team member
• A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

[Copilot]

Pull request overview

Validates and updates CI to run cleanly with xUnit v3 by ensuring the necessary test runner configuration is present and the Domain test project is included in the dev-branch validation workflow.

Changes:

• Added xunit.runner.json to Architecture.Tests and ensured it’s copied to the test output.
• Updated Architecture.Tests package references to use xunit.v3 (and analyzers) instead of xunit.
• Updated squad-preview.yml to include dotnet test for tests/Domain.Tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
tests/Architecture.Tests/xunit.runner.json	Introduces xUnit runner configuration consistent with other test projects (parallelization, method display).
tests/Architecture.Tests/Architecture.Tests.csproj	Switches Architecture.Tests to xUnit v3 packages and copies xunit.runner.json to output.
.github/workflows/squad-preview.yml	Adds Domain.Tests execution to the dev-branch preview validation workflow.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.53%. Comparing base (29415ad) to head (f1b15f8).
⚠️ Report is 2 commits behind head on sprint/8-xunit-v3-pilot.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           sprint/8-xunit-v3-pilot     #183   +/-   ##
========================================================
  Coverage                    72.53%   72.53%           
========================================================
  Files                           43       43           
  Lines                          721      721           
  Branches                       112      112           
========================================================
  Hits                           523      523           
  Misses                         149      149           
  Partials                        49       49           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.