squad(226): add missing charter sections for gandalf, legolas, pippin, ralph, sam, scribe

[mpaulosky]

Summary

Working as Boromir (Senior .NET Developer & Squad Coordinator)

This PR adds missing sections to 6 agent charters that lacked the full standard structure.

Closes #226

Changes

• gandalf: added ## Expertise and ## Critical Rules
• legolas: added ## Critical Rules
• pippin: added ## Critical Rules
• ralph: added ## Identity, ## Expertise, ## Boundaries, ## Critical Rules
• sam: added ## Critical Rules
• scribe: added ## Identity, ## Expertise, ## Boundaries, ## Critical Rules

⚠️ This task was flagged as 'needs review' — please have Aragorn review before merging.

[github-actions]

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

• The squad Lead will review and assign to an appropriate team member
• A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

[github-actions]

Test Results Summary

273 tests  ±0   273 ✅ ±0   16s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  6 files   ±0     0 ❌ ±0 

Results for commit abb1034. ± Comparison against base commit 6e33b47.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.64%. Comparing base (6e33b47) to head (265f97d).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #231   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files          43       43           
  Lines         721      721           
  Branches      112      112           
=======================================
  Hits          567      567           
  Misses        108      108           
  Partials       46       46           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR addresses squad maintenance by filling in missing standard charter sections (Identity/Expertise/Boundaries/Critical Rules) across several Squad agents to improve consistency and clarity in how each agent should operate on the MyBlog repo.

Changes:

• Added missing charter sections for Gandalf, Legolas, Pippin, Sam, Ralph, and Scribe.
• Expanded coordinator/meta-agent and scribe charters with Identity/Expertise/Boundaries/Critical Rules content.
• Introduced/standardized “Critical Rules” blocks for multiple agents.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
.squad/agents/scribe/charter.md	Adds Identity/Expertise/Boundaries/Critical Rules to formalize Scribe’s operating model.
.squad/agents/sam/charter.md	Adds a Critical Rules section for backend/dev workflow guardrails.
.squad/agents/ralph/charter.md	Adds Identity/Expertise/Boundaries/Critical Rules for the squad meta-agent/coordinator role.
.squad/agents/pippin/charter.md	Adds Critical Rules to reinforce documentation governance constraints.
.squad/agents/legolas/charter.md	Adds Critical Rules around UI conventions, testing expectations, and theme/FOUC constraints.
.squad/agents/gandalf/charter.md	Adds Expertise and Critical Rules to round out the security reviewer charter.

[mpaulosky]

Aragorn — Lead Developer Review ✅ APPROVED

PR: squad(226): add missing charter sections for gandalf, legolas, pippin, ralph, sam, scribe

Rebase Resolution

Branch had one conflict in .squad/agents/pippin/charter.md: dev had already added a ## Model section via squad(222), while this PR tried to insert ## Critical Rules in the same location. Resolved by keeping both sections — ## Model retained, ## Critical Rules appended immediately after. All other files merged cleanly.

Content Review

All 6 charters reviewed against the standard format (aragorn, gimli, boromir as reference):

• gandalf: ## Expertise and ## Critical Rules added correctly. Domain-specific rules (no-secrets, no-merge, escalate architectural decisions) are appropriate for the Security Officer role.
• legolas: ## Critical Rules added with 7 rules covering component naming, no backend in Blazor, bUnit mandatory, FOUC prevention, and GH Pages rebuild obligation. Correct and thorough.
• pippin: ## Critical Rules added with 6 rules on doc accuracy, ADR immutability, no architecture decisions, traceability. Model section preserved.
• ralph: Full ## Identity, ## Expertise, ## Boundaries, ## Critical Rules added. Appropriate for the squad meta-agent/coordinator role.
• sam: ## Critical Rules added with 7 rules enforcing Result, FluentValidation, endpoint dispatch, copyright headers. Correct backend guardrails.
• scribe: Full ## Identity, ## Expertise, ## Boundaries, ## Critical Rules added. Appropriate for the documentation/history role.

Copilot Automated Review

Read and acknowledged. Copilot reviewed all 6 files with 4 inline comments — no blocking issues flagged.

Verdict

All sections follow the established charter pattern. Content is accurate and domain-appropriate. Conflict resolution preserves all intent from both sides. Branch rebased onto current dev and force-pushed. Ready to merge.