chore(skills): clean up legacy skill paths (#240)

[mpaulosky]

Closes #240

Summary

Promotes canonical workspace skills into .github/skills, retargets squad playbooks to canonical skill locations, removes redundant legacy .copilot/.agents skill copies after migration cleanup, and preserves only the legacy-path references that are still intentionally retained.

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✨ Feature (non-breaking change that adds functionality)
• ♻️ Refactor (no behavior change, code cleanup/restructure)
• 🧪 Tests (new or updated tests only)
• 📝 Docs (README, XML docs, comments)
• ⚙️ Infra/CI (GitHub Actions, Aspire, NuGet, deployment)
• 🔒 Security (auth, permissions, secrets, headers)
• 💥 Breaking change (existing behavior changes)

Domain Affected

• 🏗️ Architecture / domain logic / CQRS → Aragorn required
• 🔧 Backend (handlers, repositories, API endpoints, MediatR) → Sam required
• ⚛️ Frontend (Blazor components, Razor pages, CSS, JS) → Legolas required
• 🧪 Unit / bUnit / integration tests → Gimli required
• 🧪 E2E / Playwright / Aspire integration tests → Pippin required
• ⚙️ CI/CD / GitHub Actions / NuGet / Aspire AppHost → Boromir required
• 🔒 Auth0 / authorization / security-relevant changes → Gandalf required
• 📝 Docs / README / XML docs → Frodo required

Self-Review Checklist

Code Quality

• I ran dotnet build MyBlog.slnx --configuration Release — leaving unchecked; current GitHub build checks are failing
• I ran dotnet test MyBlog.slnx --configuration Release --no-build — leaving unchecked; current GitHub build checks are failing
• No TODO/FIXME left unless tracked in a follow-up issue (link it)
• No secrets, API keys, or credentials committed

Architecture

Not applicable for this revision cycle — this PR changes markdown skills/playbooks only; no production handlers, DTOs, models, or domain dependencies were introduced.

Tests

Not applicable for this revision cycle — this PR does not add or modify production code or automated tests.

Security (check if security-relevant)

No auth or authorization behavior changed in the pushed revision. The touched secret-handling skill content is documentation/process guidance only.

Merge Readiness

• PR description is complete — reviewers should not have to ask what this does
• CI checks are green (current failing checks: CodeQL/Analyze (csharp), Test Suite/Build Solution (Release), Squad CI/build)
• PR is mergeable with the base branch (MERGEABLE)

Screenshots / Evidence

• No UI changes.
• Local branch gates at push time: pre-commit markdownlint gate passed; pre-push hook passed during branch push.
• GitHub currently shows 3 failing checks, 4 successful checks, and 10 skipped checks on this PR.

Notes for Reviewers

• skills-lock.json remains intentionally uncommitted because it appears unrelated to issue [Sprint 14] Cleanup legacy skill paths and duplicate workspace skill copies #240.
• Follow-up fixes are already prepared locally for:
  • .squad/playbooks/pr-merge-process.md
  • .github/skills/to-prd/SKILL.md
  • .github/skills/secret-handling/SKILL.md
  • .github/skills/github-multi-account/SKILL.md
• Those follow-up fixes are not pushed in this revision yet, so the related Copilot threads will stay open until the next commit/push lands and CI is rerun.

[github-actions]

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

• The squad Lead will review and assign to an appropriate team member
• A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

[github-actions]

Test Results Summary

273 tests  ±0   273 ✅ ±0   15s ⏱️ -1s
  6 suites ±0     0 💤 ±0 
  6 files   ±0     0 ❌ ±0 

Results for commit e3754bf. ± Comparison against base commit 127348c.

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

This PR completes the post-migration cleanup for “skills” documentation by retargeting playbooks to canonical skill locations, adding/promoting canonical skills under .github/skills, and standardizing markdown formatting while reducing legacy-path references.

Changes:

• Updated squad playbooks to reference canonical skill paths (primarily .squad/skills/* and .github/skills/*).
• Added/promoted multiple skills into .github/skills (TDD, PRD/issues conversion, architecture review, workflow/security guidance, etc.).
• Performed markdown cleanup/normalization (tables, emphasis, whitespace) across many skill docs and examples.

Reviewed changes

Copilot reviewed 31 out of 43 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
.squad/playbooks/pre-push-process.md	Retargets pre-push skill reference to canonical .squad/skills path.
.squad/playbooks/pr-merge-process.md	Retargets skill links and reformats reviewer gate table (currently has a rendering issue).
.github/skills/windows-compatibility/SKILL.md	Minor example formatting change in Windows compatibility guidance.
.github/skills/to-prd/SKILL.md	Adds a “conversation → PRD” publishing skill (has an internal instruction conflict).
.github/skills/to-issues/SKILL.md	Adds a “plan/PRD → issues” vertical-slice breakdown skill.
.github/skills/test-discipline/SKILL.md	Adds a skill reinforcing test-update discipline on API changes.
.github/skills/tdd/tests.md	Adds TDD examples for good/bad tests.
.github/skills/tdd/SKILL.md	Adds a TDD skill (philosophy + workflow + checklist).
.github/skills/tdd/refactoring.md	Adds refactor-candidate guidance for post-GREEN cycles.
.github/skills/tdd/mocking.md	Adds mocking guidance and .NET-oriented examples.
.github/skills/tdd/interface-design.md	Adds interface-design guidance for testability.
.github/skills/tdd/deep-modules.md	Adds “deep modules” guidance and examples.
.github/skills/session-recovery/SKILL.md	Adds session recovery guidance using session_store queries.
.github/skills/secret-handling/SKILL.md	Reformats secret-handling guidance (table formatting currently broken).
.github/skills/reviewer-protocol/SKILL.md	Minor markdown emphasis formatting update.
.github/skills/reskill/SKILL.md	Table formatting tweak in reskill instructions.
.github/skills/project-conventions/SKILL.md	Minor markdown whitespace normalization.
.github/skills/init-mode/SKILL.md	Markdown emphasis normalization in init-mode instructions.
.github/skills/improve-codebase-architecture/SKILL.md	Adds a skill for identifying “deepening opportunities” in architecture.
.github/skills/improve-codebase-architecture/LANGUAGE.md	Adds shared vocabulary for the architecture-improvement skill.
.github/skills/improve-codebase-architecture/INTERFACE-DESIGN.md	Adds “design it twice” interface exploration process.
.github/skills/improve-codebase-architecture/DEEPENING.md	Adds dependency categories and testing strategy for deepening work.
.github/skills/humanizer/SKILL.md	Adds tone-enforcement guidance for external-facing responses.
.github/skills/history-hygiene/SKILL.md	Minor markdown emphasis normalization.
.github/skills/grill-with-docs/SKILL.md	Adds a grilling workflow that cross-references docs and updates glossary/ADRs.
.github/skills/grill-with-docs/CONTEXT-FORMAT.md	Adds a CONTEXT.md format specification.
.github/skills/grill-with-docs/ADR-FORMAT.md	Adds an ADR format specification.
.github/skills/grill-me/SKILL.md	Adds a minimal grilling skill variant.
.github/skills/github-multi-account/SKILL.md	Adds multi-account gh alias setup guidance (currently hard-codes another repo/usernames).
.github/skills/gh-auth-isolation/SKILL.md	Adds guidance for isolating gh auth across identities.
.github/skills/external-comms/SKILL.md	Table formatting/whitespace normalization and section spacing.
.github/skills/economy-mode/SKILL.md	Table formatting normalization for economy-mode configuration.
.github/skills/docs-standards/SKILL.md	Minor formatting tweak in docs standards examples.
.github/skills/distributed-mesh/sync-mesh.sh	Whitespace cleanup.
.github/skills/distributed-mesh/sync-mesh.ps1	Whitespace cleanup.
.github/skills/distributed-mesh/SKILL.md	Minor emphasis/spacing updates.
.github/skills/distributed-mesh/mesh.json.example	Adds a mesh.json example file.
.github/skills/cross-squad/SKILL.md	Updates example content and normalizes quotes in TS snippet.
.github/skills/client-compatibility/SKILL.md	Table formatting + semicolon normalization in example snippet.
.github/skills/ci-validation-gates/SKILL.md	Table formatting normalization for “known failure modes”.
.github/skills/architectural-proposals/SKILL.md	Minor whitespace normalization in proposal templates.
.github/skills/agent-conduct/SKILL.md	Adds a centralized “hard rules” conduct skill.
.github/skills/agent-collaboration/SKILL.md	Adds centralized collaboration patterns skill.

Comments suppressed due to low confidence (1)

.github/skills/secret-handling/SKILL.md:53

• This 3-column table is currently broken into many columns because the regex patterns contain unescaped | characters, and some patterns were also altered (e.g., spaces/new escapes like \s\*). As written, it won't render as an accurate "Pattern Type / Examples / Regex Pattern" table. Escape literal pipes inside the regex column (e.g., \| / |) or move the regexes out of a table into a fenced code block list so the patterns stay intact.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.64%. Comparing base (127348c) to head (e3754bf).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #241   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files          43       43           
  Lines         721      721           
  Branches      112      112           
=======================================
  Hits          567      567           
  Misses        108      108           
  Partials       46       46           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.