Align squad model and roster guidance#25
Merged
Conversation
Align squad model-selection guidance with the active task-aware policy, then reconcile roster, routing, and casting metadata with the current charters and review workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
SummarySummary
CoverageAppHost - 0%
Domain - 93.4%
ServiceDefaults - 0%
Web - 69.5%
|
There was a problem hiding this comment.
Pull request overview
This PR updates Squad’s “source-of-truth” docs and metadata to reflect the current roster, routing ownership, and task-aware model selection guidance across the repo’s templates, GitHub agent instructions, and Copilot skills.
Changes:
- Updated model-selection guidance (defaults, fallback chains, and examples) to the current model set (e.g., Sonnet 4.6 / Opus 4.6 / GPT 5.4 variants).
- Reassigned roster roles and routing ownership (notably Gandalf ↔ Frodo, and code review routing to Aragorn) and aligned casting registry metadata.
- Adjusted multiple agent charters to use
autowith updated per-task model expectations.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| .squad/templates/squad.agent.md | Updates template agent model-selection guidance, fallback chains, and catalog list. |
| .github/agents/squad.agent.md | Mirrors the template’s model-selection guidance for GitHub agent usage. |
| .copilot/skills/model-selection/SKILL.md | Updates fallback chain guidance inside the Copilot skill. |
| .copilot/skills/economy-mode/SKILL.md | Updates “normal mode” model references used by economy-mode routing. |
| .copilot/skills/client-compatibility/SKILL.md | Updates CLI spawn example to Sonnet 4.6. |
| .squad/team.md | Updates active roster roles to match current charters/intent. |
| .squad/routing.md | Re-routes security/auth ownership and assigns code review routing to Aragorn. |
| .squad/casting/registry.json | Aligns casting registry roles/notes with updated roster. |
| .squad/agents/sam/charter.md | Moves model guidance to auto with updated resolution note. |
| .squad/agents/legolas/charter.md | Moves model guidance to auto with updated resolution note. |
| .squad/agents/gimli/charter.md | Moves model guidance to auto with updated resolution note. |
| .squad/agents/gandalf/charter.md | Refines auto model guidance by task category (premium/standard/fast). |
| .squad/agents/boromir/charter.md | Switches model guidance to auto with task-based notes. |
| .squad/agents/aragorn/charter.md | Updates model guidance for reviewer gates/architecture vs review/triage. |
Update the squad workflow so push-capable work resolves an existing open issue first and only creates a new issue when no open match exists. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Comment on lines
409
to
+412
| ``` | ||
| Premium: claude-opus-4.6 → claude-opus-4.6-fast → claude-opus-4.5 → claude-sonnet-4.5 → (omit model param) | ||
| Standard: claude-sonnet-4.5 → gpt-5.2-codex → claude-sonnet-4 → gpt-5.2 → (omit model param) | ||
| Fast: claude-haiku-4.5 → gpt-5.1-codex-mini → gpt-4.1 → gpt-5-mini → (omit model param) | ||
| Premium: claude-opus-4.6 → claude-opus-4.5 → claude-sonnet-4.6 → claude-sonnet-4.5 → (omit model param) | ||
| Standard: claude-sonnet-4.6 → gpt-5.4 → claude-sonnet-4.5 → gpt-5.3-codex → claude-sonnet-4 → gpt-5.2 → (omit model param) | ||
| Fast: claude-haiku-4.5 → gpt-5.4-mini → gpt-4.1 → gpt-5-mini → (omit model param) |
There was a problem hiding this comment.
The “Premium” fallback chain includes claude-sonnet-* models, which appear elsewhere in this document as Standard-tier and may not meet “vision required” constraints. Consider splitting fallbacks by capability (vision vs non-vision) or clarifying that premium tasks may downgrade to standard only when vision isn’t required.
Comment on lines
+154
to
+155
| GitHub MCP tools when available; otherwise use `gh issue list` or | ||
| `gh issue search`. |
There was a problem hiding this comment.
gh issue search is not a standard GitHub CLI subcommand; this guidance will fail when users follow it. Use gh search issues ... or gh issue list --search "..." as the CLI fallback when MCP tools aren’t available.
Suggested change
| GitHub MCP tools when available; otherwise use `gh issue list` or | |
| `gh issue search`. | |
| GitHub MCP tools when available; otherwise use `gh issue list --search "..."` | |
| or `gh search issues ...`. |
Comment on lines
+154
to
+155
| GitHub MCP tools when available; otherwise use `gh issue list` or | ||
| `gh issue search`. |
There was a problem hiding this comment.
gh issue search is not a standard GitHub CLI subcommand; this guidance will fail when users follow it. Use gh search issues ... or gh issue list --search "..." as the CLI fallback when MCP tools aren’t available.
Suggested change
| GitHub MCP tools when available; otherwise use `gh issue list` or | |
| `gh issue search`. | |
| GitHub MCP tools when available; otherwise use | |
| `gh issue list --search "..."` or `gh search issues ...`. |
Comment on lines
+109
to
+115
| If a model is unavailable (rate limit, plan restriction), retry within the same | ||
| tier until the documented chain is exhausted: | ||
|
|
||
| ``` | ||
| Premium: claude-opus-4.6 → claude-opus-4.6-fast → claude-opus-4.5 → claude-sonnet-4.6 | ||
| Premium: claude-opus-4.6 → claude-opus-4.5 → claude-sonnet-4.6 → claude-sonnet-4.5 | ||
| Standard: claude-sonnet-4.6 → gpt-5.4 → claude-sonnet-4.5 → gpt-5.3-codex → claude-sonnet-4 | ||
| Fast: claude-haiku-4.5 → gpt-5.1-codex-mini → gpt-4.1 → gpt-5-mini | ||
| Fast: claude-haiku-4.5 → gpt-5.4-mini → gpt-4.1 → gpt-5-mini |
There was a problem hiding this comment.
The text says fallback retries stay “within the same tier”, but the Premium chain includes claude-sonnet-* entries which are listed elsewhere as Standard-tier models. Either adjust the wording (e.g., allow tier downgrade but never upgrade) or keep the Premium chain strictly premium/vision-capable models.
Comment on lines
409
to
+412
| ``` | ||
| Premium: claude-opus-4.6 → claude-opus-4.6-fast → claude-opus-4.5 → claude-sonnet-4.5 → (omit model param) | ||
| Standard: claude-sonnet-4.5 → gpt-5.2-codex → claude-sonnet-4 → gpt-5.2 → (omit model param) | ||
| Fast: claude-haiku-4.5 → gpt-5.1-codex-mini → gpt-4.1 → gpt-5-mini → (omit model param) | ||
| Premium: claude-opus-4.6 → claude-opus-4.5 → claude-sonnet-4.6 → claude-sonnet-4.5 → (omit model param) | ||
| Standard: claude-sonnet-4.6 → gpt-5.4 → claude-sonnet-4.5 → gpt-5.3-codex → claude-sonnet-4 → gpt-5.2 → (omit model param) | ||
| Fast: claude-haiku-4.5 → gpt-5.4-mini → gpt-4.1 → gpt-5-mini → (omit model param) |
There was a problem hiding this comment.
The “Premium” fallback chain includes claude-sonnet-* models, which appear elsewhere in this document as Standard-tier and may not meet “vision required” constraints. Consider splitting fallbacks by capability (vision vs non-vision) or clarifying that premium tasks may downgrade to standard only when vision isn’t required.
| - Ask the user only when multiple open issues are plausible matches. | ||
| ```bash | ||
| gh issue list --state open --limit 50 --json number,title,body,labels | ||
| gh issue search "repo:{owner}/{repo} state:open {keywords}" |
There was a problem hiding this comment.
The workflow examples use gh issue search ..., which is not a standard GitHub CLI command. Replace with gh search issues ... (or gh issue list --search "...") so the documented commands work on a stock gh install.
Suggested change
| gh issue search "repo:{owner}/{repo} state:open {keywords}" | |
| gh search issues "repo:{owner}/{repo} state:open {keywords}" |
| ```bash | ||
| # Prefer MCP/server integrations when available. CLI fallback: | ||
| gh issue list --state open --limit 50 --json number,title,body,labels | ||
| gh issue search "repo:{owner}/{repo} state:open {keywords}" |
There was a problem hiding this comment.
The issue lookup block uses gh issue search ..., which is not a standard GitHub CLI command. Replace with gh search issues ... (or gh issue list --search "...") so the documented fallback works.
Suggested change
| gh issue search "repo:{owner}/{repo} state:open {keywords}" | |
| gh search issues "repo:{owner}/{repo} state:open {keywords}" |
Comment on lines
+109
to
+115
| If a model is unavailable (rate limit, plan restriction), retry within the same | ||
| tier until the documented chain is exhausted: | ||
|
|
||
| ``` | ||
| Premium: claude-opus-4.6 → claude-opus-4.6-fast → claude-opus-4.5 → claude-sonnet-4.6 | ||
| Premium: claude-opus-4.6 → claude-opus-4.5 → claude-sonnet-4.6 → claude-sonnet-4.5 | ||
| Standard: claude-sonnet-4.6 → gpt-5.4 → claude-sonnet-4.5 → gpt-5.3-codex → claude-sonnet-4 | ||
| Fast: claude-haiku-4.5 → gpt-5.1-codex-mini → gpt-4.1 → gpt-5-mini | ||
| Fast: claude-haiku-4.5 → gpt-5.4-mini → gpt-4.1 → gpt-5-mini |
There was a problem hiding this comment.
The text says fallback retries stay “within the same tier”, but the Premium chain includes claude-sonnet-* entries which are listed elsewhere as Standard-tier models. Either adjust the wording (e.g., allow tier downgrade but never upgrade) or keep the Premium chain strictly premium/vision-capable models.
mpaulosky
added a commit
that referenced
this pull request
May 8, 2026
## Summary Merges 4 pending inbox decisions into `.squad/decisions.md`: - **Decision #22:** Aragorn gate — PR #272 Release Sprint 18 approved - **Decision #23:** Aragorn gate — PR #273 AppHost.Tests flake hardening approved - **Decision #24:** Gimli — Two-tier test strategy for AppHost Clear Command (#248) - **Decision #25:** Gimli — TDD as default approach (charter supplement) Also updates agent history files for Aragorn, Boromir, Sam, and Scribe. No source code changes. Squad docs only. --- _Opened by Scribe (squad automation)_ --------- Co-authored-by: Boromir <boromir@squad.dev> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #20
Summary
Validation