chore(squad): archive self-authored PR gate skill (#337)#338
Merged
Conversation
…tory - Document self-authored PR gate workflow for lead-only reviews (GitHub blocks self-approval) - Record PR #336 gate decisions: CI green, Copilot clean, specialist reviews collected, squash merged - Add learning: self-approval blocked by GitHub; lead gate can proceed with documented checks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
github-actions
Bot
added
the
squad
There was a problem hiding this comment.
Pull request overview
Documents and archives the “self-authored PR gate” workflow for cases where GitHub blocks PR self-approval, and records the PR #336 gate outcome in Aragorn’s history log.
Changes:
- Added a new Squad skill documenting the self-authored PR gate workflow.
- Appended a PR #336 gate review/merge record to Aragorn’s agent history.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .squad/skills/self-authored-pr-gate/SKILL.md | New skill doc describing required checks and workflow when self-approval is blocked. |
| .squad/agents/aragorn/history.md | History entry capturing PR #336 gate/merge actions and learnings. |
Comment on lines
+1
to
+7
| --- | ||
| name: self-authored-pr-gate | ||
| confidence: high | ||
| description: > | ||
| Lead-gate workflow for PRs where the reviewer account is also the PR author | ||
| and GitHub blocks self-approval. | ||
| --- |
|
|
||
| 1. CI is fully green (build, tests, security, coverage checks). | ||
| 2. Copilot automated review has no unresolved bug/security findings. | ||
| 3. Codecov shows no material regression (>= 1% decrease blocks merge). |
| - Ran parallel specialist reviews (Aragorn + Boromir perspectives) and merged with squash into `dev`. | ||
| - Synced local `dev`, pruned merged `squad/*` branches, and removed the merged remote branch. | ||
|
|
||
| ## Learnings |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #338 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 51 51
Lines 1369 1369
Branches 166 166
=======================================
Hits 1118 1118
Misses 184 184
Partials 67 67 🚀 New features to boost your workflow:
|
Owner
Author
|
🚫 PR gate status: NOT review-ready yet I ran the Aragorn gate for PR #338. Core gates are green (CI/checks, mergeable, branch naming, and Closes #337), but merge is blocked on unresolved review findings:
🔒 Blocking action posted: author should address these review findings on the same branch, then rerun gate. After fixes are pushed and checks stay green, I will re-run the final merge gate immediately. |
… semantics - Add 'domain: PR governance, code review, CI/CD' and 'source: earned' front matter - Revise Codecov check to emphasize investigation/explanation over unconditional hard block - Align language with repo policy: ≥1% decrease requires investigation, not automatic merge block Closes #337 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Document front matter alignment and skill template compliance - Record Codecov policy semantics decision: investigate-and-explain vs. hard block - Learning: skill front matter is structural; Codecov gate intent is transparency Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
✅ Aragorn final gate complete: all required checks green (including Coverage Analysis), Copilot review read, Codecov shows no decrease (81.66% → 81.66%), mergeable confirmed. Proceeding with squash merge per playbook. |
mpaulosky
pushed a commit
that referenced
this pull request
May 15, 2026
**Orchestration:** Created orchestration logs for Gimli, Frodo, Legolas, Sam, Boromir; created session log for issue #341 polish. **Decisions:** Merged PR #336 self-authored gate handling, PR #338 process-contract blocking, and PR #340 categories gate outcome from inbox → decisions.md. Deleted inbox files. **Agent History:** Appended Boromir issue #341 orchestration notes to .squad/agents/boromir/history.md. **Status:** Issue #341 (PR #342 polish cycle) complete. All team members' work recorded. Decisions committed to long-lived history. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #337
Changes
Testing
Context
This skill documents the pattern discovered when Boromir's self-authored PR #336 (Aspire/markdown upgrade) required Aragorn's lead review without self-approval. GitHub returns
422: Can not approve your own pull request, so the gate relied on CI/Copilot/Codecov checks instead.