Skip to content

fix: resolve dev/main conflicts blocking PR #427#428

Merged
mpaulosky merged 3 commits into
devfrom
squad/427-dev-conflict-fix
Jul 4, 2026
Merged

fix: resolve dev/main conflicts blocking PR #427#428
mpaulosky merged 3 commits into
devfrom
squad/427-dev-conflict-fix

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Resolves merge conflicts that block #427 (dev -> main).\n\nIncludes:\n- Conflict resolution from main into dev\n- Required formatting fix to satisfy pre-push gate\n\nValidation run locally via pre-push gate:\n- markdownlint\n- dotnet format verify\n- Release build\n- Architecture/Domain/Web/Web.Bunit tests\n- Integration tests (Web + AppHost)\n\nOnce merged into dev, PR #427 should become mergeable.\n\nRefs #427

Copilot AI review requested due to automatic review settings July 4, 2026 14:35
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

  • The squad Lead will review and assign to an appropriate team member
  • A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

@github-actions github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Jul 4, 2026
@mpaulosky
mpaulosky enabled auto-merge (squash) July 4, 2026 14:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Resolves merge conflicts between dev and main that were blocking PR #427, including a small formatting correction needed to satisfy the repo’s pre-push validation gates.

Changes:

  • Fixes a formatting/indentation issue in AspireManager to satisfy dotnet format verify.
  • Resolves merge-conflict artifacts and reconciles the resulting dependency lock state in src/Web/package-lock.json.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
tests/AppHost.Tests/Infrastructure/AspireManager.cs Corrects formatting in the Aspire test builder configuration block.
src/Web/package-lock.json Removes merge-conflict remnants and reconciles the resolved lockfile contents.
Files not reviewed (1)
  • src/Web/package-lock.json: Generated file

@mpaulosky
mpaulosky merged commit f4781d2 into dev Jul 4, 2026
8 of 9 checks passed
@mpaulosky
mpaulosky deleted the squad/427-dev-conflict-fix branch July 4, 2026 14:37
@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (bcd1aae) to head (ce338a2).
⚠️ Report is 15 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #428       +/-   ##
===========================================
- Coverage   87.49%   76.73%   -10.77%     
===========================================
  Files          71       71               
  Lines        1775     1775               
  Branches      214      214               
===========================================
- Hits         1553     1362      -191     
- Misses        145      336      +191     
  Partials       77       77               

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mpaulosky added a commit that referenced this pull request Jul 4, 2026
Follow-up conflict resolution after #428 merge.\n\nThis PR resolves the
remaining merge conflicts between origin/dev and origin/main that still
blocked #427.\n\nValidation:\n- Full local pre-push gate passed (build +
tests + integration)\n\nRefs #427

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Boromir <boromir@squad.dev>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: GitHub Copilot <copilot@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Boromir <lead-organizer@squad.local>
Co-authored-by: mpaulosky <mpaulosky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad Squad triage inbox — Lead will assign to a member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants