Skip to content

fix: align AspireManager conflict for #427 (v5)#432

Merged
mpaulosky merged 2 commits into
devfrom
squad/427-dev-conflict-fix-v5
Jul 4, 2026
Merged

fix: align AspireManager conflict for #427 (v5)#432
mpaulosky merged 2 commits into
devfrom
squad/427-dev-conflict-fix-v5

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Targets the remaining dev/main conflict for #427 by aligning AspireManager to main.

  • updates only tests/AppHost.Tests/Infrastructure/AspireManager.cs
  • full local pre-push gates passed

Refs #427

Copilot AI review requested due to automatic review settings July 4, 2026 15:27
@mpaulosky
mpaulosky enabled auto-merge (squash) July 4, 2026 15:27
@github-actions github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

  • The squad Lead will review and assign to an appropriate team member
  • A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

@mpaulosky
mpaulosky merged commit 2161687 into dev Jul 4, 2026
6 of 8 checks passed
@mpaulosky
mpaulosky deleted the squad/427-dev-conflict-fix-v5 branch July 4, 2026 15:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the AspireManager test infrastructure helper with main to resolve the remaining conflict from #427 by adjusting the DistributedApplicationTestingBuilder.CreateAsync call site formatting.

Changes:

  • Updated indentation/formatting around the configureBuilder lambda in AspireManager to match the main branch’s expected shape.
  • No functional test behavior changes intended (test-only file).

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (9ba31ec) to head (dc74c77).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #432   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files          71       71           
  Lines        1775     1775           
  Branches      214      214           
=======================================
  Hits         1362     1362           
  Misses        336      336           
  Partials       77       77           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad Squad triage inbox — Lead will assign to a member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants