Skip to content

fix: align main conflict hotspots with dev for #427#435

Merged
mpaulosky merged 1 commit into
mainfrom
squad/427-main-conflict-alignment
Jul 4, 2026
Merged

fix: align main conflict hotspots with dev for #427#435
mpaulosky merged 1 commit into
mainfrom
squad/427-main-conflict-alignment

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Unblocks PR #427 by harmonizing the remaining conflict hotspots in main.

  • .github/workflows/squad-standard-lint-markdown.yml
  • .github/workflows/squad-standard-lint-yaml.yml
  • tests/AppHost.Tests/Infrastructure/AspireManager.cs

Refs #427

Copilot AI review requested due to automatic review settings July 4, 2026 15:53
@mpaulosky
mpaulosky enabled auto-merge (squash) July 4, 2026 15:53
@github-actions github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

  • The squad Lead will review and assign to an appropriate team member
  • A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns main with dev in a few remaining conflict hotspots to unblock PR #427, focusing on CI lint workflows and a small formatting-only change in the AppHost test infrastructure.

Changes:

  • Update YAML and Markdown lint workflows to use actions/checkout@v7 and lint only files changed in PRs (while linting all files on workflow_dispatch).
  • Switch Markdown lint invocation from markdownlint-cli to markdownlint-cli2.
  • Fix indentation/formatting in AspireManager.cs (no behavior change).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/AppHost.Tests/Infrastructure/AspireManager.cs Formatting-only indentation alignment in builder configuration callback.
.github/workflows/squad-standard-lint-yaml.yml Updates checkout action and scopes yamllint to changed YAML files on PRs.
.github/workflows/squad-standard-lint-markdown.yml Updates checkout action, scopes markdown lint to changed files on PRs, and uses markdownlint-cli2.

Comment on lines +22 to +25
if [ "${{ github.event_name }}" = "pull_request" ]; then
base_ref="origin/${{ github.base_ref }}"
git fetch --no-tags --depth=1 origin "${{ github.base_ref }}"
files=$(git diff --name-only "${base_ref}...HEAD" -- '*.yml' '*.yaml' | tr '\n' ' ')
Comment on lines +20 to +23
if [ "${{ github.event_name }}" = "pull_request" ]; then
base_ref="origin/${{ github.base_ref }}"
git fetch --no-tags --depth=1 origin "${{ github.base_ref }}"
files=$(git diff --name-only "${base_ref}...HEAD" -- '*.md' | tr '\n' ' ')
@mpaulosky
mpaulosky merged commit f780ff5 into main Jul 4, 2026
18 of 20 checks passed
@mpaulosky
mpaulosky deleted the squad/427-main-conflict-alignment branch July 4, 2026 15:56
@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (4e1a700) to head (8851434).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files          71       71           
  Lines        1775     1775           
  Branches      214      214           
=======================================
  Hits         1362     1362           
  Misses        336      336           
  Partials       77       77           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad Squad triage inbox — Lead will assign to a member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants