ci: enable squad-test workflow for sprint/* branches (closes #69) - #70
Merged
Conversation
- PR #62: APPROVE — pre-push hook logic verified, clean infra fix - PR #63: conditional APPROVE — build confirmation needed before merge - PR #60: NEEDS_CHANGES — dirty state, missing copyright headers, wrong attribution - Systemic finding: squad-test.yml does not trigger on sprint/** PRs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add push trigger for sprint/** so direct pushes to sprint branches trigger the parallel test suite - Add sprint/** to pull_request.branches so PRs targeting sprint consolidation branches also run CI validation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
squad
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
Contributor
SummarySummary
CoverageAppHost - 0%
Domain - 87.2%
ServiceDefaults - 0%
Web - 68.7%
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Enables the squad-test.yml CI workflow to run for the sprint consolidation branch flow (squad/* → sprint/* → dev → main), closing the validation gap for PRs targeting sprint/* branches.
Changes:
- Added a
pushtrigger forsprint/**in.github/workflows/squad-test.yml. - Added
sprint/**to thepull_request.branchestrigger list so PRs targeting sprint branches run CI. - Appended a Sprint 3 gate review note to Aragorn’s squad history.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/squad-test.yml |
Expands workflow triggers to include sprint branch pushes and PR bases. |
.squad/agents/aragorn/history.md |
Documents the Sprint 3 PR gate review and the discovered CI gap. |
|
|
||
| ### Systemic Finding: CI Gap on `sprint/**` Branches | ||
|
|
||
| `squad-test.yml` triggers on PRs targeting `main`, `dev`, `squad/**` — but NOT `sprint/**`. All Sprint 3 PRs bypass the build/test pipeline. Pre-push gates run locally but provide no remote CI verification. A follow-up issue should be opened to add `sprint/**` to the CI trigger list. |
There was a problem hiding this comment.
The history entry says a follow-up issue "should be opened" to add sprint/** to the CI triggers, but this PR is already implementing that fix (and is closing #69). Consider updating this sentence to reflect the current state (e.g., issue opened and addressed by this PR) so the history remains accurate.
Suggested change
| `squad-test.yml` triggers on PRs targeting `main`, `dev`, `squad/**` — but NOT `sprint/**`. All Sprint 3 PRs bypass the build/test pipeline. Pre-push gates run locally but provide no remote CI verification. A follow-up issue should be opened to add `sprint/**` to the CI trigger list. | |
| `squad-test.yml` triggers on PRs targeting `main`, `dev`, `squad/**` — but NOT `sprint/**`. All Sprint 3 PRs bypass the build/test pipeline. Pre-push gates run locally but provide no remote CI verification. Follow-up issue #69 was opened to add `sprint/**` to the CI trigger list, and this PR addresses that fix. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
sprint/**to the CI trigger insquad-test.yml.Changes:
pushtrigger forsprint/**— so direct pushes to sprint consolidation branches run the parallel test suitesprint/**topull_request.branches— so PRs targeting sprint branches (e.g. squad/* → sprint/*) also trigger CIBranch flow:
squad/*→sprint/*→dev→mainSprint branches are consolidation checkpoints. Without this fix, sprint-level PRs ran with zero remote validation.
Closes #69
Working as Boromir (DevOps/Infra)