[Sprint 3] Fix install-hooks.sh Gate 0 description to include sprint/* branches - #78
Merged
Conversation
…t/* [Sprint 3]
The pre-push hook already supports sprint/{N}-{slug} branches (early-exit
after Gate 0 naming check), but install-hooks.sh still only mentioned
squad/{issue}-{slug} in its Gate 0 description. Update the summary text to
accurately document both valid branch patterns.
Merge hierarchy: squad/* → sprint/* → dev → main (release only)
Closes #61
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
squad
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
Contributor
SummarySummary
CoverageAppHost - 0%
Domain - 87.2%
ServiceDefaults - 0%
Web - 69.4%
|
There was a problem hiding this comment.
Pull request overview
Updates the developer-facing hook installation output so it accurately describes Gate 0 behavior for both squad/* and sprint/* branch workflows, aligning the documentation with the already-merged pre-push hook logic.
Changes:
- Update
scripts/install-hooks.shGate 0 description to mention bothsquad/{issue}-{slug}andsprint/{N}-{slug}patterns. - Clarify that
sprint/*passes Gate 0 and exits (skipping feature gates).
Comment on lines
62
to
+64
| echo "The hook enforces 5 gates on every 'git push':" | ||
| echo " 0. Enforces squad/{issue}-{slug} branch naming" | ||
| echo " 0. Enforces branch naming — squad/{issue}-{slug} runs all gates;" | ||
| echo " sprint/{N}-{slug} passes Gate 0 and exits (skips feature gates)" |
There was a problem hiding this comment.
The message "The hook enforces 5 gates on every 'git push'" is now misleading because sprint/* branches exit after Gate 0 (per .github/hooks/pre-push). Consider rewording this line to clarify that all 5 gates run on squad/* branches, while sprint/* runs only Gate 0 and then exits.
mpaulosky
enabled auto-merge (squash)
April 20, 2026 17:52
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Working as Boromir (DevOps / Infra)
Closes #61
The pre-push hook Gate 0 fix for
sprint/*branches was already merged via PR #62 intosprint/3-mongodb-persistence(and subsequently intodev). The one remaining gap:scripts/install-hooks.shstill printed an outdated Gate 0 description that only mentionedsquad/{issue}-{slug}.This PR updates the install-hooks.sh output text to accurately document both valid branch patterns.
Changes
scripts/install-hooks.sh— Gate 0 description now lists both patterns:squad/{issue}-{slug}→ runs all gates (build + tests)sprint/{N}-{slug}→ passes Gate 0, exits (skips feature gates)Merge hierarchy
Acceptance Criteria
git push origin sprint/*passes without--no-verify(hook fix in dev via PR [Sprint 3] Fix pre-push Gate 0 to allow sprint/* branches #62)scripts/install-hooks.shdescription accurately reflects sprint/* support