display progress status for both mplayer and mpv#47
Merged
np1 merged 2 commits intomps-youtube:popen-non-slavefrom Mar 9, 2014
Merged
display progress status for both mplayer and mpv#47np1 merged 2 commits intomps-youtube:popen-non-slavefrom
np1 merged 2 commits intomps-youtube:popen-non-slavefrom
Conversation
Contributor
|
Fantastic! So far it's working well with mpv audio and video. Will do a bit more testing. Well done! The stderr redirection in your most recent commit work. I was making very similar changes but was setting stderr=subprocess.PIPE within Popen.subprocess(). Was that wrong? I see you set stderr=subprocess.STDOUT Thanks again! |
Contributor
Author
|
|
np1
added a commit
that referenced
this pull request
Mar 9, 2014
display progress status for both mplayer and mpv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warning: tested only with mplayer. Make sure to test it with mpv before merging