Assorted fixes for a Win32 build from PowerShell#18056
Open
amyspark wants to merge 3 commits into
Open
Conversation
This fixes compiling when using Windows-style paths in the Meson configuration line, e.g. > '-Dc_args=-IC:\mpv\subprojects\amf-headers'
Replace `cp` with an inline Python script.
…figuration For some reason, there does is a default version set for libjxl, but not for libjxl_threads. This makes Meson reject the latter as a valid override for what's requested by FFmpeg (>= 0.7.0, instead detected as undefined).
kasper93
reviewed
Jun 1, 2026
Member
There was a problem hiding this comment.
The
libjxl_threadsoverride couldn't be accepted by the FFmpeg wrap because of a missing version (it checks for 0.7.0 or higher)
Which CMake version do you use? This is known regression in CMake 4.1.1, but was seemingly fixed in 4.1.2 and onward. I have not seen this issue since. See mesonbuild/meson#15530 for more details.
| command: [ | ||
| python, | ||
| '-c', | ||
| 'import shutil; import sys; shutil.copy(sys.argv[1], sys.argv[2])', |
Member
There was a problem hiding this comment.
Commit prefix should be ci/win32: ... or something, it's not subrandr change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
Coming here from https://gitlab.freedesktop.org/gstreamer/meson-ports/ffmpeg/-/work_items/75, this is a MR to address the issues I found when trying to set up mpv as per the Windows build instructions.
I found the following bits:
libjxl_threadsoverride couldn't be accepted by the FFmpeg wrap because of a missing version (it checks for 0.7.0 or higher)cpto move a generated static library, which is not available under PowerShell (easily fixable with an inline Python script)meson.build_options()which was added in meson: bump required version to 1.3.0 #14907 needs one to also escape backslashes properly, otherwise they are interpreted by Clang as escape sequences.All feedback is appreciated. Thanks in advance for the review!