4.3 Release#27
Merged
Merged
Conversation
Update not pushed live at time of update due to a few bugs. Wanted to get commit in. Fixed typo with mist.utils.NMToMeters causing function not to work. added Logger 'dbLog' to mist DB code inserted do-end blocks to make DB code block shorter in length Purpose of DB updating refactor is to more accurately keep unit tables updated correctly. In the old system only 'byName' DBs were updated if a group/unit name was duplicated. So it was possible for multiple units to share the same name in unitsByNum, byCat, etc. The process of how it checks added groups and units has been altered slightly. Groups spawned with player controlled units will not be updated. The conditions for whether or not the table gets updated are as follows: If groupName is already in DB then check if its groupId, country, or coalition changed. If nothing has changed then it checks if the newly spawned units exist in a DB entry and if so it will verify if the unitId ort ype have changed. Any single update prompts the DB to update accordingly.
Some minor fixes to code implemented last update Updated mission used to create DBs. There should no longer be any unit names that are the same as group names. Dynamically generated names will now be indexed accordingly to their category. Used to be just a single counter shared between all. Several changes and fixes to dynAddStatic -Fixed function wasn't working when given certain params. -fixed country checker to better account for country names with spaces. This fix was applied to dynAdd but not dynAddStatic, I corrected this. -Optimized it slightly. Trimmed the fat of some of the code.
Set loggers to warning level.
Added some error checking functionality to existing functions.
This is the shapeNames DB. It is a simple look up table for static objects which may require a shapename to correctly spawn static objects.
Re-export of DBs and updated files needed for release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge 4.3 changes
-Refactored DB update code. If a groupName or unitName is duplicated it will now overwrite the older DB entry for all "live" DBs
-Several fixes for dnyAddStatic function
--Optimized it by trimming excess code out.
--fixed country checker to better account for country names with spaces
--fixed function was broken if given certain params
-dynAdd functions now index names by category.
-Added mist.DBs.const.shapeNames DB. This is simply a table of static object names and their corresponding shape names.