isTerrainValid validation for terrain types table fails with multiple entries#45
Merged
Merged
Conversation
terrainTypes table index is no longer being compared with SurfaceType enum values, leading to incorrect type inclusions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing a table of terrain types compares the
terrainTypestable index against DCS'SurfaceTypeenum values, always including theLANDsurface type if more than one terrainType was provided.Example:
I assume the second check when validating the provided
terrainTypestable is intended to allow the enum's values to be provided as well, e.g. asmist.isTerrainTypes(_terrainPoint, {'WATER', 3}), however the comparison incorrectly checks the table's index against the enum's values.This PR fixes the comparison, checking the assummed intended
terrainTypesvalue against theSurfaceTypeenum value.Happy to provide a short demo mission/script to showcase the issue if required 😄