Open
Conversation
this is a naive changeset in the interest of support for pseudo-elements in pesticide. it's not ready to be pulled in, but I wanted to get a little bit of discussion going. here are the notes: 1. this changeset only adds `outline` support. to fully support pseudoelements, you'd probably want to add depth rules for `before` and `after` too. 2. didn't mess with the color table. should there be entries there for `before` and `after` too? 3. I manually added rulesets for stylus, less, and scss. this is a fairly-complete, awesome library, but what's the best process to follow when a change does need to be introduced? (i.e., of the steps I've taken here, what's missing?) 4. looks like the current `css/pesticide.css` is actually a stylus file. is that just a bug? in my changeset here, I wrote the file as though it was a stylus file to avoid formatting differences. 5. I didn't re-generate the minified CSS file. regenerating that file from master looks like it's significantly different from whatever's checked in, so I didn't want to add any noise. probably best to handle whatever's going on there in another branch, assuming there's an issue there.
|
Pseudo elements are relevant for layout bugs, they should be outlined too. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a naive changeset in the interest of support for pseudo-elements in
pesticide. it's not ready to be pulled in, but I wanted to get a little
bit of discussion going. here are the notes:
outlinesupport. to fully supportpseudoelements, you'd probably want to add depth rules for
beforeandaftertoo.color_table.json. should there be entries therefor
beforeandaftertoo?fairly-complete, awesome library, but what's the best process to follow
when a change does need to be introduced? (i.e., of the steps I've taken
here, what's missing?)
css/pesticide.cssis actually a stylusfile. is that just a bug? in my changeset here, I wrote the file as
though it was a stylus file to avoid formatting differences.
from master looks like it's significantly different from whatever's
checked in, so I didn't want to add any noise. probably best to handle
whatever's going on there in another branch, assuming there's an issue
there.