fix(homelab): fix flinker model API response parsing and enrich model metadata#67
Merged
Merged
Conversation
fetchFlinkerModels() was reading data.models[].name but the OpenAI-compatible endpoint returns data.data[].id, causing flinker/Qwen models to always resolve to an empty object and never appear in the generated ConfigMap.
Extract --ctx-size for limit.context/output, filter out embedding models (--embeddings flag) and placeholder entries (no --model/--hf-repo arg), set tool_call:true, and include a loaded/unloaded label in the model name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchFlinkerModels()was readingdata.models[].namebut the OpenAI-compatible/v1/modelsendpoint returnsdata.data[].id— models were always silently dropped, resulting in an empty flinker providerstatus.argsfrom flinker's response to extract meaningful model metadata:--ctx-size→limit.context/limit.output(capped at 32 768)--embeddingsflag) and empty placeholders (no--model/--hf-repo)tool_call: truefor all exposed modelsname("qwen3.6-35b-a3b (local, loaded)")Testing
tsc --noEmitpasses cleanly