Avoid memory copy in MessagePacker.writePayload #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Use the source ByteBuffet directly to avoid memory copy | ||
|
|
||
| // First, flush the current buffer contents | ||
| out.flush(buffer, 0, position); |
Member
There was a problem hiding this comment.
You can call MessagePacker.flush.
Member
|
I don't have good idea for the threshold. We need to measure the performance. |
|
|
||
| public MessagePacker writePayload(ByteBuffer src) throws IOException { | ||
| if(src.remaining() >= FLUSH_THRESHOLD) { | ||
| // Use the source ByteBuffet directly to avoid memory copy |
Member
There was a problem hiding this comment.
(trivial) ByteBuffet -> ByteBuffer
Member
|
👍 |
Member
Author
|
OK. Check the appropriate buffer size later. I filed this issue in #89. |
xerial
added a commit
that referenced
this pull request
May 13, 2014
Avoid memory copy in MessagePacker.writePayload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement based on the discussion #82 (diff).
Currently it uses 512 bytes as threshold for using the input source ByteBuffer/array directly in writePayload. I'm not sure this value is appropriate or not. Any idea on this?