fix: datetime before epoch on windows in cython implementation#436
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 5 5
Lines 847 847
=======================================
Hits 746 746
Misses 101 101 Continue to review full report at Codecov.
|
Contributor
Author
|
Not sure what is wrong in the C/C++ analysis. Please help me and I will fix it. |
methane
reviewed
Jul 30, 2020
methane
reviewed
Jul 30, 2020
methane
reviewed
Jul 30, 2020
Cython implementation still used datetime.from_timestamp method, which does not work on windows. Update the cython implementation to use utc time and delta and add a regression test to highlight the issue.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cython implementation still used datetime.from_timestamp method, which does not work on windows.
Update the cython implementation to use utc time and delta
and add a regression test to highlight the issue.