Fix the bug of checkpoint saving induced by path formatting. - #10
Open
Leixinjonaschang wants to merge 1 commit into
Open
Fix the bug of checkpoint saving induced by path formatting.#10Leixinjonaschang wants to merge 1 commit into
Leixinjonaschang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When saving the checkpoint, encountered error message: TypeError: unsupported operand type(s) for +: 'PosixPath' and 'str'.
Here, the checkpoint dir is a pathlib.Path object (PosixPath on Linux). The Path object does not support direct concatenation of strings using the plus sign +.
Change
Updated checkpoint saving line in PARC/diffusion/mdm.py
Impact
The checkpoint can be saved successfully after the change.