Skip to content

GitHub CI: Run memory profiling with valgrind on Linux and FreeBSD#13

Merged
msteinert merged 4 commits into
mainfrom
rdmark-valgrind-in-ci
Aug 11, 2025
Merged

GitHub CI: Run memory profiling with valgrind on Linux and FreeBSD#13
msteinert merged 4 commits into
mainfrom
rdmark-valgrind-in-ci

Conversation

@rdmark

@rdmark rdmark commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

Use the built-in valgrind wrapper in Meson to run memory profiling in the CI pipeline

It might be possible to use valgrind on other platforms than Linux and FreeBSD, but these two were the ones that worked out of the box

Use the built-in valgrind wrapper in Meson to run memory profiling in the CI pipeline
@rdmark
rdmark force-pushed the rdmark-valgrind-in-ci branch from fe23b02 to d5b8c13 Compare August 7, 2025 19:45
@rdmark rdmark changed the title GitHub CI: Run memory profiling with valgrind GitHub CI: Run memory profiling with valgrind on Linux and FreeBSD Aug 7, 2025
@rdmark
rdmark requested a review from msteinert August 7, 2025 19:48
@rdmark

rdmark commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

@msteinert any other parameter apart from --leak-check=full --error-exitcode=1 to make the Meson wrapper run the same tests as your automake wrapper?

For the record, I was able to get the valgrind wrapper up and running on Solaris on OmniOS as well, but it is reporting leaks. More analysis required before turning it on in the pipeline.

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2025

Copy link
Copy Markdown

@msteinert

Copy link
Copy Markdown
Owner

This is great! I think we may want to consider dropping Autotools at some point now...

@msteinert
msteinert merged commit c312c5e into main Aug 11, 2025
24 of 25 checks passed
@rdmark
rdmark deleted the rdmark-valgrind-in-ci branch August 11, 2025 17:48
@rdmark

rdmark commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator Author

The only user of Autotools that I know of is the YACP project. (A Cygwin package repo.)

https://github.com/fd00/yacp/tree/master/bstring

How about we can keep Autotools in the next stable release but flag in the release notes that it will be removed in the subsequent release?

@msteinert

Copy link
Copy Markdown
Owner

Sounds like a good plan.

I recognize the most recent contributor to that package...

@rdmark

rdmark commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator Author

Right, I leaned in to get the package bumped from 1.0.0 to 1.0.1.

I had never used YACP before, but it was flagged by Repology: https://repology.org/project/bstring/versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants