Abort tests when encountering NULL pointers#16
Merged
Conversation
Abort instead of assert on NULL pointer to avoid using NULL pointer as parameter in function where this leads to undefined behavior Also, consistently use ck_abort() rather than ck_abort_msg() with message, since the messages are redundant to the context of a test failure
rdmark
force-pushed
the
return-after-abort
branch
from
August 12, 2025 06:43
6335032 to
ef7b926
Compare
|
msteinert
approved these changes
Aug 12, 2025
msteinert
left a comment
msteinert
left a comment
Owner
There was a problem hiding this comment.
Seems unfortunate that libcheck asserts don't end the test execution. This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abort instead of assert on NULL pointer to avoid using NULL pointer as parameter in function where this leads to undefined behavior
Also, consistently use ck_abort() rather than ck_abort_msg() with message, since the messages are redundant to the context of a test failure