Skip to content

Record GitHub action versions in code comment and remove timeouts#35

Merged
rdmark merged 2 commits into
mainfrom
action-versions
Aug 25, 2025
Merged

Record GitHub action versions in code comment and remove timeouts#35
rdmark merged 2 commits into
mainfrom
action-versions

Conversation

@rdmark

@rdmark rdmark commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Consistently keep track of the action version numbers, which will be recognized and kept updated by dependabot

Also, the vmactions runners have been improved with retry logic, so let's remove the timeouts for now

Consistently keep track of the action version numbers, which will be recognized and kept updated by dependabot
@rdmark
rdmark requested a review from msteinert August 20, 2025 18:12
@github-actions

github-actions Bot commented Aug 20, 2025

Copy link
Copy Markdown

File Coverage Lines Branches
All files 68% 73% 63%
bstring/bstraux.c 55% 64% 46%
bstring/bstrlib.c 73% 76% 69%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against d1a2c4e

The vmactions runners have been improved with retry logic, so let's remove the timeouts for now
@rdmark rdmark changed the title Record GitHub action versions in code comment Record GitHub action versions in code comment and remove timeouts Aug 20, 2025
@sonarqubecloud

Copy link
Copy Markdown

@rdmark
rdmark merged commit 1483bed into main Aug 25, 2025
16 checks passed
@rdmark
rdmark deleted the action-versions branch August 25, 2025 05:07
@msteinert

Copy link
Copy Markdown
Owner

I was wondering about these. Usually when I configure actions I use the tag, e.g.

- uses: actions/checkout@v4

What's the reasoning for using hashes instead of tags?

@rdmark

rdmark commented Aug 25, 2025

Copy link
Copy Markdown
Collaborator Author

Good question! The idea is that tags are mutable and therefore susceptible to supply chain attacks. So it adds a layer of control and transparency by pinning all dependencies (including CI runner dependencies) to hashes and then use dependabot, renovate or similar to manage updates.

This is part of OpenSSF best practices, specifically this rule: https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies

If you're curious, the OpenSSF scorecard as applied to my other project: https://scorecard.dev/viewer/?uri=github.com/Netatalk/netatalk

If you like, I can set up a scorecard for bstring and see how many points we get. :)

@msteinert

Copy link
Copy Markdown
Owner

Sounds good to me if you want to spend the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants