Skip to content

Define project C standard to C99#46

Merged
msteinert merged 1 commit into
mainfrom
45-building-tests-requires-c99-can--stdc99-be-passed-when-tests-are-enabled
Sep 5, 2025
Merged

Define project C standard to C99#46
msteinert merged 1 commit into
mainfrom
45-building-tests-requires-c99-can--stdc99-be-passed-when-tests-are-enabled

Conversation

@rdmark

@rdmark rdmark commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

The codebase's baseline is close to C99, with a good balance of familar code and backwards compatibility

The codebase's baseline is close to C99, with a good balance of familar code and backwards compatibility
@rdmark
rdmark requested a review from msteinert September 5, 2025 05:59
@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown

File Coverage Lines Branches
All files 68% 73% 63%
bstring/bstraux.c 55% 64% 46%
bstring/bstrlib.c 73% 76% 69%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 8521166

@msteinert
msteinert merged commit 36d3f0f into main Sep 5, 2025
16 checks passed
@msteinert

Copy link
Copy Markdown
Owner

Wow, that "duplicate code" check is draconian. Do you have any idea why that Ubuntu CI job failed yesterday?

Is it a good time to cut a release, or do you have more incoming?

@rdmark
rdmark deleted the 45-building-tests-requires-c99-can--stdc99-be-passed-when-tests-are-enabled branch September 5, 2025 15:36
@rdmark

rdmark commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

I think the Ubuntu failures were because of GitHub deb repo proxy service disruptions. The job failed to install dependent packages. I had the same issue in my other GitHub project yesterday.

This is a good time to cut a release!

@msteinert

Copy link
Copy Markdown
Owner

This is a good time to cut a release!

https://github.com/msteinert/bstring/releases/tag/v1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building tests requires C99, can -std=c99 be passed when tests are enabled?

2 participants