Cross-platform check for compiler warning flags with Windows support#52
Merged
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8616e2b |
rdmark
marked this pull request as ready for review
September 8, 2025 05:45
Collaborator
Author
|
Next up I'm thinking it would be worth setting up a job that uses the MSVC compiler which is what most people would use on Windows, but it seems a bit more complicated. One approach described here https://dvdhrm.github.io/2021/04/21/meson-msvc-github-actions/ Edit: Added! But I couldn't figure out how to easily run the unit tests with check on MSVC. |
rdmark
force-pushed
the
windows-build
branch
2 times, most recently
from
September 8, 2025 17:57
01411c9 to
343144b
Compare
rdmark
changed the title
First build uses gcc in an MSYS2 environment, the second native Microsoft Visual C
rdmark
force-pushed
the
windows-build
branch
from
September 8, 2025 17:57
343144b to
39bb4c7
Compare
rdmark
changed the title
rdmark
force-pushed
the
windows-build
branch
3 times, most recently
from
September 8, 2025 19:44
6f099f5 to
3333308
Compare
rdmark
changed the title
rdmark
force-pushed
the
windows-build
branch
2 times, most recently
from
September 9, 2025 05:27
14f4eb5 to
6248d72
Compare
When using Microsoft Visual C on Windows, use a different set of warning flags than the usual Unix compilers Also, use warning_level=3 to get the -Wpedantic flag rather than hard coding it
rdmark
force-pushed
the
windows-build
branch
from
September 9, 2025 05:40
6248d72 to
8616e2b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Microsoft Visual C on Windows, use a different set of warning flags than with the usual Unix compilers
Also, use warning_level=3 to get the -Wpedantic flag rather than hard coding it
Create Windows build jobs in the GitHub workflow: First build uses gcc in an MSYS2 environment, the second native Microsoft Visual C